RFR: String.join(), StringJoiner additions (original) (raw)

Martin Buchholz martinrb at google.com
Mon Apr 15 18:14:14 UTC 2013

Is "i+1" really preferred to "i + 1" ? I thought it was the reverse, and that "i+1" was merely tolerated.

1570 if (value[i] == hi && value[i+1] == lo) {

2425 * @throws NullPointerException If {@code delimiter} is {@code null}

you also throw NPE for element null, but you didn't specify that. * * ---

On Thu, Apr 11, 2013 at 3:33 PM, Jim Gish <jim.gish at oracle.com> wrote:

Please review http://cr.openjdk.java.net/~jgish/Bugs-5015163-7175206- 7172553/ <http://cr.openjdk.java.net/~jgish/Bugs-5015163-7175206-7172553/><_ _http://cr.openjdk.java.net/%**7Ejgish/Bugs-5015163-7175206-**7172553/<http://cr.openjdk.java.net/%7Ejgish/Bugs-5015163-7175206-7172553/> >

These are changes that we made in lambda that we're now bringing into JDK8. I've made a couple of additions - making StringJoiner final and adding a couple of constructors to set the emptyOutput chars. Thanks, Jim -- Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304 Oracle Java Platform Group | Core Libraries Team 35 Network Drive Burlington, MA 01803 jim.gish at oracle.com

More information about the core-libs-dev mailing list