RFR 8010280: jvm.cfg needs updating for non-server builds (original) (raw)

Mandy Chung mandy.chung at oracle.com
Tue Apr 16 17:51:05 UTC 2013

On 4/15/2013 3:42 PM, David Holmes wrote:

FYI updated webrev at same location, removing the dead code Erik spotted.

http://cr.openjdk.java.net/~dholmes/8010280/webrev/

Looks good to me. Nit: CopyFiles.gmk line 340 - you may want to remove the extra space to align with the next line.

I've attached all the generated versions below.

Thanks for the generated files that are helpful for the review. Have you considered adding a simple sanity test, if not present, to validate jvm.cfg matches with the vm binaries bundled in JAVA_HOME? Just a thought and maybe you can file a RFE to add such a test later if you think it's a good idea.

Mandy

More information about the core-libs-dev mailing list