RFR: JDK-8011920 (Main implementation classes for java.util.stream) (original) (raw)
Jonathan Gibbons jonathan.gibbons at oracle.com
Fri Apr 19 01:23:07 UTC 2013
- Previous message: RFR: JDK-8011920 (Main implementation classes for java.util.stream)
- Next message: RFR : 8008670 : Initial java.util.stream putback -- internal API classes
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Brian,
Are you asking for people to review the code, just to get some warm fuzzy feedback, or are you asking for a formal review of the code with the direct goal of pushing 15K LOC into jdk8/tl with no corresponding tests.
If you are looking to push bits soon, why can't you wait until you have everything ready?
-- Jon
On 04/18/2013 05:40 PM, Brian Goetz wrote:
This is a review request for the bulk of the java.util.stream implementation; webrev at:
http://cr.openjdk.java.net/~briangoetz/JDK-8011920/webrev/ You might ask: with 15,000 lines of new code, why are there no tests? The simple answer is: we've got plenty of 'em, but they can't be put back until all the source goes back. So until then, I'll just show you the coverage report for java.util.stream: http://cr.openjdk.java.net/~briangoetz/JDK-8011920/Coverage.pdf So...we have tests. We'll put them back soon.
- Previous message: RFR: JDK-8011920 (Main implementation classes for java.util.stream)
- Next message: RFR : 8008670 : Initial java.util.stream putback -- internal API classes
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]