RFR: 8001647: In-place methods on Collection/List (original) (raw)
Alan Bateman Alan.Bateman at oracle.com
Sun Apr 21 11:33:02 UTC 2013
- Previous message: RFR: 8001647: In-place methods on Collection/List
- Next message: RFR: 8001647: In-place methods on Collection/List
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 20/04/2013 02:39, Akhil Arora wrote:
On 04/19/2013 04:15 AM, Alan Bateman wrote:
On 18/04/2013 19:49, Akhil Arora wrote:
Looks like the stars are aligning on getting on this into TL... the refreshed webrev is -
http://cr.openjdk.java.net/~akhil/8001647.8/webrev/ A minor comment on Collection.removeIf is "that satisifies the given predicate" might be better than "which matches the provided predicate". Also for completeness, you could say "RuntimeExceptions and Errors thrown by the predicate are propagated ...". fixed both Thanks, I see the update to Collection.removeIf. I don't see the update to List.replaceAll so that could be changed to be consistent before you push this.
I looked through the latest webrev (8001647.9) and don't see any other issues.
-Alan.
- Previous message: RFR: 8001647: In-place methods on Collection/List
- Next message: RFR: 8001647: In-place methods on Collection/List
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]