RFR: 8007395 StringIndexOutofBoundsException in Match.find() when input String contains surrogate UTF-16 characters (original) (raw)

Xueming Shen xueming.shen at oracle.com
Fri Apr 26 20:17:15 UTC 2013

On 04/26/2013 01:09 PM, Mandy Chung wrote:

On 4/26/2013 10:25 AM, Xueming Shen wrote: Hi

Please help review the proposed fix for 8007395: StringIndexOutofBoundsException in Match.find() when input String contains surrogate UTF-16 characters http://cr.openjdk.java.net/~sherman/8007395/webrev This looks fine with me. The new test case you add in RegExTest.java catches the exception. It might be better to let the exception thrown as in the existing test cases that will make it easier to diagnose in such error case.

Hi Mandy,

Thanks for the review.

The "usual convention" in RegTest is to catch the exception and increase the failureCount so the test can keep going even some tests "unexpected" throw exception. The test will fail with RuntimeException at the end if the failureCount>0.

-Sherman

Mandy

More information about the core-libs-dev mailing list