RFR JDK-8012645: Stream methods on BitSet, Random, ThreadLocalRandom, ZipFile (original) (raw)

Alan Bateman Alan.Bateman at oracle.com
Sat Apr 27 15:01:34 UTC 2013

On 27/04/2013 00:08, Henry Jen wrote:

Hi,

Please review webrev at http://cr.openjdk.java.net/~henryjen/ccc/8012645.0/webrev The API doc in specdiff format is at http://cr.openjdk.java.net/~henryjen/ccc/8012645.0/specdiff Cheers, Henry In the ZipFile spec it reads "Entries appear in the {@code Stream} in the order they appear in the ZIP file" but I think the order of the entries in the central directory and this may not be the same as the order of the entries in the archive.

I'm still a newbie on the Spliterator characteristics so bear with me. In BitSet.stream then the spliterator is created as SORTED, is that right? I'm also wondering about the characteristics when creating the ZipFile and JarFile streams, should it include DISTINCT?

The tests looks good. One suggestion for StreamZipEntriesTest is to include a test to check that ISE is thrown when stream is invoked on a closed ZipFile.

-Alan.

More information about the core-libs-dev mailing list