RFR: 8009389: Unpack200 native library should be removed from profiles (original) (raw)
David Holmes david.holmes at oracle.com
Tue Apr 30 07:55:49 UTC 2013
- Previous message: RFR: 8009389: Unpack200 native library should be removed from profiles
- Next message: RFR: 8009389: Unpack200 native library should be removed from profiles
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi Kumar,
On 30/04/2013 8:05 AM, Kumar Srinivasan wrote:
Hi,
Please review this fix which will enable profiles and embedded distros to eliminate the unpack200 binaries saving space, all this does is switch to the java implementation if the native one cannot be found. http://cr.openjdk.java.net/~ksrini/8009389/webrev.0/
Minor nit: why the duplicate code instead of having only the unpack in the try-catch:
} else {
try { (new NativeUnpack(this)).run(in0, out);
} catch (UnsatisfiedLinkError ule) {
// failover to java implementation
(new DoUnpack()).run(in0, out); } in0.close(); Utils.markJarFile(out);
}
Thanks, david
Thanks Kumar
- Previous message: RFR: 8009389: Unpack200 native library should be removed from profiles
- Next message: RFR: 8009389: Unpack200 native library should be removed from profiles
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]