RFR: 8013155: [pack200] improve performance of pack200 (original) (raw)
Kumar Srinivasan kumar.x.srinivasan at oracle.com
Tue Apr 30 18:32:38 UTC 2013
- Previous message: RFR: 8013155: [pack200] improve performance of pack200
- Next message: RFR: 8013155: [pack200] improve performance of pack200
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi Alex,
Great job identifying this hot method. I realize the code is complicated but optimized for speed.
Couple of nits: I don't think you need the parens
j = (nextsemi < nextangl ? nextsemi : nextangl);
Coding conventions nits: missing spaces for operators.
for (int i = firstl+1, j; i > 0; i = sig.indexOf('L', j)+1) {
I take it all the regression tests have been run ? in jdk/test/tools/pack200.
Thanks Kumar
Please review this fix which by fine-tuning of just one method gives up to 40% performance improvement on packing and repacking of jar files. Also removed unneeded local variable initialization from Code class - not for performance gain, just to make world a better place.
- Previous message: RFR: 8013155: [pack200] improve performance of pack200
- Next message: RFR: 8013155: [pack200] improve performance of pack200
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]