Codereview request for 8006295: Base64.Decoder.wrap(java.io.InputStream) returns InputStream which throws unspecified IOException on attempt to decode invalid Base64 byte stream (original) (raw)
Alan Bateman Alan.Bateman at oracle.com
Fri Feb 1 09:43:00 UTC 2013
- Previous message: Codereview request for 8006295: Base64.Decoder.wrap(java.io.InputStream) returns InputStream which throws unspecified IOException on attempt to decode invalid Base64 byte stream
- Next message: Codereview request for 8006295: Base64.Decoder.wrap(java.io.InputStream) returns InputStream which throws unspecified IOException on attempt to decode invalid Base64 byte stream
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 31/01/2013 23:20, Xueming Shen wrote:
Any opinion of an ioe based specific InvalidedBase64BytesException is more appropriate/preferred/desired in this kinda of situation? The argument against the IAE is probably that an IAE may be a surprise for someone working on inputstream.read(). -Sherman I just replied to your original mail, as IAE doesn't make sense here.
I guess the question on whether you need a specialized exception comes down to whether it would be useful to take recovery action that would be different to other I/O exceptions that might happen. If we don't have good use-cases then it's probably not worth doing it now, it is always something that could be added later if really needed (as it shouldn't break anyone to throw a more specific exception in the future).
-Alan
- Previous message: Codereview request for 8006295: Base64.Decoder.wrap(java.io.InputStream) returns InputStream which throws unspecified IOException on attempt to decode invalid Base64 byte stream
- Next message: Codereview request for 8006295: Base64.Decoder.wrap(java.io.InputStream) returns InputStream which throws unspecified IOException on attempt to decode invalid Base64 byte stream
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]