RFR (S) 8007142: Add utility classes for writing better multiprocess tests in jtreg (original) (raw)

Alan Bateman Alan.Bateman at oracle.com
Fri Feb 1 12:32:12 UTC 2013

On 01/02/2013 12:12, Yekaterina Kantserova wrote:

Hi everyone,

Here comes a http://cr.openjdk.java.net/~ykantser/8007142/webrev.01/ with following fixes compared to .00: * new line is added at the end of the StreamPumper.java * is changed to {@code in the StreamPumper.java * JDKToolFinder.java will use the system property "java.home" instead of "test.jdk" (thus -compilejdk problem is solved) I see you've changed the package to jdk.testlibrary - thanks for doing that.

On JDKToolFinder and finding the path to jcmd or other tools used by the test then it really depends what you are testing. What you have is fine when testing a JDK but it's not going to work when testing a JRE (runtime only, no tools). When testing a runtime then jtreg needs to invoked the -jdk and -compilejdk options (the latter being the JDK to use to compile the tests). So I think the right answer for JDKToolFinder is to use "compile.jdk". That will work when testing a JDK too as "compile.jdk" and "test.jdk" are set to the same value for that case.

-Alan

More information about the core-libs-dev mailing list