Code review request for 8007113 Upgrade AnnotatedElement.isAnnotionPresent to be a default method (original) (raw)

Joe Darcy joe.darcy at oracle.com
Fri Feb 1 19:16:11 UTC 2013

Hi Joel,

On 2/1/2013 1:47 AM, Joel Borggrén-Franck wrote:

Hi Joe,

On 02/01/2013 04:21 AM, Joe Darcy wrote: Hello,

I'd like to upgrade the existing AnnotatedElement.isAnnotationPresent interface method to a default method: 8007113 Upgrade AnnotatedElement.isAnnotionPresent to be a default method http://cr.openjdk.java.net/~darcy/8007113.0/ How about sun/reflect/generics/reflectiveObjects/TypeVariableImpl.java ? It looks like I forgot to update that one when I did the type annotations changes :)

I did notice TypeVariableImpl as one of the implementers of AnnotatedElement, but since it was defined to just return false, I skipped it. However, since getAnnotation now works for type variables, that behavior is incorrect.

I'll update the webrev to cover TypeVariableImpl too.

Thanks,

-Joe

More information about the core-libs-dev mailing list