Request for review: 8007454 Wrong parameters in Win32 native code. (original) (raw)
Alan Bateman Alan.Bateman at oracle.com
Mon Feb 4 14:25:17 UTC 2013
- Previous message: Request for review: 8007454 Wrong parameters in Win32 native code.
- Next message: Request for review: 8007454 Wrong parameters in Win32 native code.
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 04/02/2013 12:28, Alexey Utkin wrote:
Hi, Please review the fix.
Bug description: http://bugs.sun.com/viewbug.do?bugid=8007454 https://jbs.oracle.com/bugs/browse/JDK-8007454 The suggested fix: http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-8007454/webrev.01/ Summary: Old version of code for the [JavajavalangProcessImplcreate] function could not work right in some cases. The [SetHandleInformation] call worked partially and just because HANDLEFLAGINHERIT == TRUE == 1 and FALSE == 0. As the parameter is a DWORD then it shouldn't be using a BOOLEAN so I agree with that.
Can you explain why HANDLE_FLAG_PROTECT_FROM_CLOSE is needed?
-Alan.
- Previous message: Request for review: 8007454 Wrong parameters in Win32 native code.
- Next message: Request for review: 8007454 Wrong parameters in Win32 native code.
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]