RR(S): 8008095.JDP-TEST3 (was Re: FAILS: test/sun/management/jdp/JdpTest.sh: test: argument expected) (original) (raw)

Chris Hegarty chris.hegarty at oracle.com
Wed Feb 13 17:21:16 UTC 2013

Looks fine to me.

-Chris.

On 13/02/2013 14:40, Dmitry Samersoff wrote:

Chris,

Please take a look at the final changes: http://cr.openjdk.java.net/~dsamersoff/8008095.JDP-TEST3/webrev.01/jdk/ I still not able to get valuable results from jprt but tried couple of different solaris machines and hope this time the problem with this test is gone. I'm ready to push it right after your response. -Dmitry On 2013-02-13 14:53, Chris Hegarty wrote: Dmitry,

I have a trivial patch that resolves this issue. I would like to push it to jdk8/tl today before we freeze for M7, and have this failure escape into master. The change is to simply use conditions that are also supported by bourne shell . diff -r 7dcb74c3ffba test/sun/management/jdp/JdpTest.sh --- a/test/sun/management/jdp/JdpTest.sh Tue Feb 12 09:25:43 2013 -0800 +++ b/test/sun/management/jdp/JdpTest.sh Wed Feb 13 10:48:28 2013 +0000 @@ -51,7 +51,7 @@ docompile(){ # sun.* packages is not included to symbol file lib/ct.sym so we have # to ignore it - if [ ! -f ${testclasses} ] + if [ ! -d ${testclasses} ] then mkdir -p ${testclasses} fi @@ -319,7 +319,7 @@ rm -f ${logname} rm -f ${logname} rm -f ${policyname} -if [ -e ${testsrc}/policy.tpl ] +if [ -f ${testsrc}/policy.tpl ] then _cat ${testsrc}/policy.tpl | _ -Chris. On 12/02/2013 22:19, Dmitry Samersoff wrote: Chris,

I'm not able to reproduce it locally. Do you have a link to jprt job you see this failure? -Dmitry On 2013-02-12 21:38, Chris Hegarty wrote: Dmitry,

This test is now failing on several platforms, on jdk8 and 7u-dev ------- result: Passed. Compilation successful #section:shell ----------messages:(3/154)---------- command: shell JdpTest.sh [--jtreg, --no-compile] reason: User specified action: run shell JdpTest.sh --jtreg --no-compile elapsed time (seconds): 0.045 ----------System.out:(0/0)---------- ----------System.err:(1/110)---------- /export2/Users/chris/repos/jdk8/tl/mastertop/jdk/test/sun/management/jdp/JdpTest.sh: test: argument expected result: Failed. Execution failed: exit code 1

test result: Failed. Execution failed: exit code 1 -Chris. On 02/12/2013 12:04 PM, dmitry.samersoff at oracle.com wrote: Changeset: f7fb173ac833 Author: dsamersoff Date: 2013-02-12 16:02 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f7fb173ac833 8007786: JDK-8002048 testcase doesn't work on Solaris Summary: test built in into Solaris shell doesn't have -e operator Reviewed-by: sla, sspitsyn ! test/sun/management/jdp/JdpTest.sh

More information about the core-libs-dev mailing list