[PATCH] Sunbug 7131192: Optimize BigInteger.doubleValue(), floatValue() (original) (raw)
Louis Wasserman lowasser at google.com
Fri Feb 22 20:10:41 UTC 2013
- Previous message: [PATCH] Sunbug 7131192: Optimize BigInteger.doubleValue(), floatValue()
- Next message: [PATCH] Sunbug 7131192: Optimize BigInteger.doubleValue(), floatValue()
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
It's up to you guys, probably. The issue is that the "reference implementation" being tested against is wrong, and which order you want to fix things is up to you guys.
On Fri, Feb 22, 2013 at 11:48 AM, Brian Burkhalter < brian.burkhalter at oracle.com> wrote:
On Feb 22, 2013, at 11:33 AM, Brian Burkhalter wrote: Sweet. Just be aware that the floatValue() optimization requires Float.parseFloat to be fixed to match IEEE 754 behavior, as you're apparently doing with Double.parseDouble, to pass tests.
Actually I missed that until yesterday but found it out myself. I do not think however that the patch for 7131192 necessarily has to precede the fix for 7192954, as long as the latter gets into the same release. Oops, I had that reversed: I don't know that the patch for 7192954 has to precede that for 7131192 if the latter is deemed correct. B.
-- Louis Wasserman
- Previous message: [PATCH] Sunbug 7131192: Optimize BigInteger.doubleValue(), floatValue()
- Next message: [PATCH] Sunbug 7131192: Optimize BigInteger.doubleValue(), floatValue()
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]