hg: jdk8/tl/jdk: 8008167: IdentityHashMap.[keySet|values|entrySet].toArray speed-up (original) (raw)

Mike Duigou mike.duigou at oracle.com
Mon Feb 25 18:28:46 UTC 2013

On Feb 25 2013, at 10:13 , Alan Bateman wrote:

On 25/02/2013 15:55, Mike Duigou wrote:

:

The webrev suggests you've replaced Map/Collisions.java and assume that is not the intention. Otherwise the new test looks okay, an alternative would have been to expand MOAT. Webrev doesn't properly recognize 'hg copy' and sees it as a rename. I started ToArray.java by copying Collisions.java Are you sure you want to do "hg copy" here? This means that hg will track the copy and I assume we don't want that here.

Some people would just do a plain shell copy of the file and then hg add the "new" file. I prefer to use an actual SCM copy because I am re-using portions of the original file. If it turns out there is a bug in the boilerplate that I copied the "hg copy" does leave a tenuous link back to the source which would still have the same bug. If I just used regular copy and then hg add then that link is broken completely.

Mike

More information about the core-libs-dev mailing list