Review request for 8009115: jtreg tests under jdk/test/javax/script should use nashorn as script engine (original) (raw)
A. Sundararajan sundararajan.athijegannathan at oracle.com
Wed Feb 27 11:20:08 UTC 2013
- Previous message: Review request for 8009115: jtreg tests under jdk/test/javax/script should use nashorn as script engine
- Next message: Review request for 8009115: jtreg tests under jdk/test/javax/script should use nashorn as script engine
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Thanks Alan. Yes, nashorn is a "js" engine as well and so user's java code can use getEngineByName("js") and get it. The current change is to make sure that javax.script tests use nashorn engine - rather than any other "js" engine that may be present in the underlying jdk.
-Sundar
On Wednesday 27 February 2013 04:47 PM, Alan Bateman wrote:
On 27/02/2013 10:44, A. Sundararajan wrote:
Hi,
Please review http://cr.openjdk.java.net/~sundar/8009115/ Changing javax.script tests to use nashorn engine explicitly. Adjusted tests for differences b/w nashorn and rhino engines. Changes documented here: http://cr.openjdk.java.net/~sundar/8009115/README Thanks -Sundar These changes look okay to me although I assumed that Nashorn would be a "js" scripting engine, in which case there shouldn't be a need to change many of the getEngineByName("js") usages to "nashorn". -Alan
- Previous message: Review request for 8009115: jtreg tests under jdk/test/javax/script should use nashorn as script engine
- Next message: Review request for 8009115: jtreg tests under jdk/test/javax/script should use nashorn as script engine
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]