RFR 8005634: TEST_BUG tools/launcher/VersionCheck.java fails version check on jdeps (original) (raw)
Mandy Chung mandy.chung at oracle.com
Wed Jan 2 16:46:18 UTC 2013
- Previous message: RFR 8005634: TEST_BUG tools/launcher/VersionCheck.java fails version check on jdeps
- Next message: Request for Review: Java SE 8 Compact Profiles
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Chris,
Looks good. I missed this test in my default jprt run and thanks for fixing it.
Mandy
On 1/2/2013 6:11 AM, Chris Hegarty wrote:
The jdeps tools (recently added by 8003562) does not support '-version'. It uses the gnu-style '--version'. It should be excluded from VersionCheck.testToolVersion(), similar to the (un)pack200 tool. Long term we may need to re-visit this test to add support for gnu-style option checking, but that is a bigger issue.
The test change is to add 'jdeps' to the list of tools that do not support '-version'. diff -r 38b9a7646093 test/tools/launcher/VersionCheck.java --- a/test/tools/launcher/VersionCheck.java Tue Jan 01 17:49:22 2013 -0800 +++ b/test/tools/launcher/VersionCheck.java Wed Jan 02 14:05:37 2013 +0000 @@ -68,6 +68,7 @@ public class VersionCheck extends TestHe "jcmd", "jconsole", "jcontrol", + "jdeps", "jinfo", "jmap", "jps",
-Chris.
- Previous message: RFR 8005634: TEST_BUG tools/launcher/VersionCheck.java fails version check on jdeps
- Next message: Request for Review: Java SE 8 Compact Profiles
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]