RFR: (jaxp) 8005473 : Warnings compiling jaxp (original) (raw)
Joe Wang huizhe.wang at oracle.com
Thu Jan 3 16:58:14 UTC 2013
- Previous message: RFR: (jaxp) 8005473 : Warnings compiling jaxp
- Next message: RFR 8005659: Add tools/pack200/AttributeTests.java to exclude list (ProblemList.txt) until pack200 updated to support method parameters
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 1/3/2013 3:33 AM, Daniel Fuchs wrote:
On 12/27/12 12:06 AM, Joe Wang wrote:
Hi,
This is a patch to clean up compiling warnings in jaxp. Bug: http://bugs.sun.com/viewbug.do?bugid=8005473 Webrev: http://cr.openjdk.java.net/~joehw/jdk8/8005473/webrev/ Thanks, Joe Hi Joe, In FactoryFinder.java - line 213, SchemaFactoryFinder.java - line 360, XPathFactoryFinder.java - line 336, I think you could simply do: return creationMethod.invoke(null); since the second parameter is a varargs...
It is. But refer to Remi's comments in this thread, that casting null is better or otherwise an empty array will be allocated each time the method is called.
Best, Joe
best regards, -- daniel
- Previous message: RFR: (jaxp) 8005473 : Warnings compiling jaxp
- Next message: RFR 8005659: Add tools/pack200/AttributeTests.java to exclude list (ProblemList.txt) until pack200 updated to support method parameters
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]