RFR 8004547: Extend JavaFX launcher support... (original) (raw)
David DeHaven david.dehaven at oracle.com
Thu Jan 3 18:38:22 UTC 2013
- Previous message: RFR : 8003228 : (props) sun.jnu.encoding should be set to UTF-8 [macosx]
- Next message: RFR 8004547: Extend JavaFX launcher support...
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
[adding core-libs-dev back in.. not sure how that got lost]
[Back from vacation, let's get the ball rolling again… :]
In order to understand and explain here is a truth table:
Cmd line FAC LAUNCHMODE JAVAFXLAUNCHMODE java -jar fxapp.jar Present LMJAR LMJAR java -jar fxapp.jar Not present LMJAR LMCLASS ?? java -cp fxapp.jar ... Not present LMCLASS LMCLASS java -cp somedir ... Not present LMCLASS LMCLASS If I am understanding this correctly, the confusion stems from the second case where the value is interpreted in different ways. Correct. I have actually changed it to fix this case, and IMHO it cleans up the launcher code a bit.. I'll post the webrev when I'm done syncing with TL.
The current patch I have: http://cr.openjdk.java.net/~ddehaven/8004547/webrev.2/
Minor change to accommodate this in FX LauncherImpl (needs a new JIRA issue?): http://cr.openjdk.java.net/~ddehaven/javafx/RT-26751/webrev.2/
This was all working fine when I left for vacation, I'm still in the process of building/testing everything and will submit a JPRT run as soon as possible.
I had commented out two tests, but FX is in sync with JDK and they'll pass vacuously until FX is on the ext classpath anyways so I don't think that's necessary.
-DrD-
- Previous message: RFR : 8003228 : (props) sun.jnu.encoding should be set to UTF-8 [macosx]
- Next message: RFR 8004547: Extend JavaFX launcher support...
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]