RFR 8005962 : TEST_BUG: java/util/Properties/MacJNUEncoding can fail in certain environments (original) (raw)

Chris Hegarty chris.hegarty at oracle.com
Fri Jan 11 17:54:42 UTC 2013

On 11/01/2013 17:50, Brent Christian wrote:

Thanks, Stuart.

I did an 'hg mv' of the directory containing the (two) test files. But I then had to 'hg export' to send the changeset for pushing. I'm guessing

Yes, I noticed this before. 'hg export' and 'hg mv' are not friends.

-Chris.

that the export wasn't able to preserve the history across the rename.

-Brent On 1/10/13 6:25 PM, Stuart Marks wrote: FYI, if the file is moved using 'hg mv' then 'hg log -f' will show the history across the rename, and 'hg diff --git' will show the rename plus diffs instead of all-lines-deleted followed by all-lines-added. Looks like this was done using rm + add instead of mv. Too late now, oh well.

s'marks On 1/10/13 11:13 AM, Brent Christian wrote: Thanks, Naoto.

AFAICT, in a case like this there where a file is moved and changes are made to it, webrev shows that the new file is renamed from the old file, but doesn't provide cdiffs/sdiffs/etc for the code changes. 'hg diff' behaves the same way WRT the code changes - it tells you that the old file was removed and the new file was added, but you don't get code diffs for the changes. (Interestingly, the NetBeans editor seemed to figure out what was happening.) That's how it works for me, anyway. -Brent On 1/10/13 10:27 AM, Naoto Sato wrote: Looks good to me.

BTW, I thought that webrev would effectively extract the diffs even when files were moved around. Naoto On 1/10/13 9:49 AM, Brent Christian wrote: Hi,

The test case for 8003228 fails in certain environments. Also the version that was pushed was missing a couple small changes. The code changes to fix these issues are here: http://cr.openjdk.java.net/~bchristi/8005962/webrev.00/ The test case will also be moved from java/util/Properties/ to java/lang/System/. Webrev wouldn't do well showing that part of the change, so it's not reflected there. Instead I generated a webrev to better show the code changes. Thanks, -Brent

More information about the core-libs-dev mailing list