review request 8006139, add missing methods to javax.sql.rowset.serial.SQLInput/OutputImpl (original) (raw)

Ulf Zibis Ulf.Zibis at CoSoCo.de
Mon Jan 21 21:46:47 UTC 2013

Am 19.01.2013 16:08, schrieb Lance Andersen - Oracle:

I looked at the latest webrev and it seems okay to me. SQLInputImpl.getNextAttribute would be bit better if it only incremented idx after retrieving an attribute but that is existing code. Minor intent issue in SQLOutputImpl. writeNClob.

fixed the spacing. going to leave idx alone for now as but will look at this for the future

... and starting idx by 0 instead -1 would not be so exotic, see:

internal review ID of 2426775

-Ulf

More information about the core-libs-dev mailing list