Request for review: 8004698: Implement Core Reflection for Type Annotations (original) (raw)
Joel Borggrén-Franck joel.franck at oracle.com
Tue Jan 22 08:40:29 UTC 2013
- Previous message: Request for review: 8004698: Implement Core Reflection for Type Annotations
- Next message: RFR: 8006090 - Formatter asserts with -esa
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi,
New webrev: http://cr.openjdk.java.net/~jfranck/8004698/webrev.01/
More comments in the code, more javadoc comments, hopefully better flow for enhanced readability.
I have also reduced permissions on some methods and made most of the classes immutable.
cheers /Joel
On 01/17/2013 05:23 PM, Joel Borggrén-Franck wrote:
Hi,
Here is a webrev for core reflection support for type annotations: http://cr.openjdk.java.net/~jfranck/8004698/webrev.00/ This code is based on the tl/jdk repository, but in order to run the tests you need a javac with type annotations support and also a recent copy of the VM that includes this change set: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/35431a769282 (This also means this code can't be pushed until all supporting pieces are in place.) Type annotations are still a bit of a moving target so there will be follow up work on this. There is no caching of annotations in this version and I am not sure how we want to do the space/time trade of for type annotations. cheers /Joel
- Previous message: Request for review: 8004698: Implement Core Reflection for Type Annotations
- Next message: RFR: 8006090 - Formatter asserts with -esa
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]