Codereview request for 8003680: JSR 310: Date/Time API (original) (raw)

Xueming Shen xueming.shen at oracle.com
Tue Jan 22 19:09:36 UTC 2013

Hi,

Webrev has been updated to address the build issue in the new build infra. M

(1) added the java.time packages into common/makefiles.javadoc/CORE_PKGS.gmk to be included into ct.sym

http://cr.openjdk.java.net/~sherman/8003680/webrev_ctrl/

(2) not sure which one should be used for lib/tzdb.jar. It appears the tzdb.jar will not be picked for "images" if use $(JDK_OUTPUTDIR)/lib and it does not get copied for "overlay-image", if use $(IMAGES_OUTPUTDIR)/lib. Guess something need to be tweak in Images.gmk. But I'm running out of time, so now I copy the tzdb into both to make both happy for M6.

http://cr.openjdk.java.net/~sherman/8003680/webrev/makefiles/GendataTZDB.gmk.html

Thanks, -Sherman

On 01/18/2013 04:03 PM, Xueming Shen wrote:

Hi,

The webrev and Javadoc have been updated based on the feedback we received so far. The main stopper is the timezone data compiler had dependency on new threeten classes (and these classes themselves depend on new JDK8 features). The compiler has been re-written to remove the dependency and now work as a "normal" build tool at make/tool. Build-infra team please help take a look if all our makefile changes are OK for the new/ old build system. http://cr.openjdk.java.net/~sherman/8003680/webrev http://cr.openjdk.java.net/~sherman/8003680/javadoc Thanks, Sherman On 01/15/2013 04:13 PM, Xueming Shen wrote: Hi,

The Threeten project [1] is planned to be integrated into OpenJDK8 M6 milestone. Here is the webrev http://cr.openjdk.java.net/~sherman/8003680/webrev and the latest javadoc http://cr.openjdk.java.net/~sherman/8003680/javadoc Review comments can be sent to the threeten-dev email list [2] and/or core-libs-dev email list[3]. Thanks, Sherman [1] http://openjdk.java.net/projects/threeten [2] threeten-dev @ openjdk.java.net [3] core-libs-dev @ openjdk.java.net

More information about the core-libs-dev mailing list