RFR 8009581: Xpathexception does not honor initcause() (original) (raw)

Jason Mehrens jason_mehrens at hotmail.com
Tue Jun 4 13:44:57 UTC 2013

Aleksej,

Looks good to me. I think Alan wanted you to use the ser files to create a byte array + ByteArrayInputStream in the actual test class instead of including actual serial data files along side the test.

Jason

The next version of webrev: http://cr.openjdk.java.net/~dmeetry/8009581/webrev.4/ <http://cr.openjdk.java.net/%7Edmeetry/8009581/webrev.4/> The list of changes: 1. The test was moved to jdk/test/javax/xml/jaxp/XPath/8009579 2. Throw of InvalidClassException was added 3. Two test cases were added: a) Deserialization of XPathException initialized by ordinary values and serialized by JDK7 build (normaljdk7.ser file) b) Deserialization of "new XPathException(new Exception()).initCause(null)" XPathException serialized by JDK7 build (twocausesjdk7.ser file).

-Aleksej [snip] > > I see you've added a serialization/deserialization test (thanks) but > it wouldn't have caught this. What would you think about serializing a > few XPathException instances with a jdk7 build and use the byte stream > in the test to check that they are handled correctly. That would give > more confident that there aren't any other holes. > > -Alan

More information about the core-libs-dev mailing list