Inefficient use StringBuffer or StringBuilder[Optimization|clean-up] {Package: con.sun. * java.lang*} (original) (raw)

Otávio Gonçalves de Santana otaviojava at java.net
Fri Jun 7 13🔞27 UTC 2013

• Previous message: RFR (S) CR 7177472: JSR292: MethodType interning penalizes scalability
• Next message: Inefficient use StringBuffer or StringBuilder[Optimization|clean-up] {Package: con.sun. * java.lang*}
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Inefficient use StringBuffer or StringBuilder[Optimization|clean-up]

The string addition in the parameter will create another string buffer, append all the components, then convert that to a string so the you can be appended to your string buffer.

So I replace this:

sb.append(" xxx: [" + getXXX() + "]\n");

for this:

sb.append(" xxx: [").append(getXXX()).append("]\n");

The classes are:

-- com.sun com.sun.tools.hat.internal.model.JavaValueArray com.sun.jmx.snmp.IPAcl.NetMaskImpl com.sun.jndi.ldap.sasl.DefaultCallbackHandler com.sun.media.sound.WaveExtensibleFileReader com.sun.org.apache.xml.internal.security.encryption.XMLCipher com.sun.org.apache.xml.internal.security.utils.RFC2253Parser com.sun.security.sasl.CramMD5Base com.sun.security.sasl.digest.DigestMD5Base com.sun.tools.example.debug.gui.ContextManager com.sun.tools.jdi.VirtualMachineImpl

-- java.lang java.lang.invoke.LambdaForm

The diff bellow:

diff --git a/src/share/classes/com/sun/tools/example/debug/gui/ContextManager.java b/src/share/classes/com/sun/tools/example/debug/gui/ContextManager.java --- a/src/share/classes/com/sun/tools/example/debug/gui/ContextManager.java +++ b/src/share/classes/com/sun/tools/example/debug/gui/ContextManager.java @@ -338,10 +338,10 @@ if (classpath.isEmpty()) { String envcp = System.getProperty("env.class.path"); if ((envcp != null) && (envcp.length() > 0)) {

•                munged.append(" -classpath " + envcp);

•                munged.append(" -classpath ").append(envcp);
             }
         } else {

•            munged.append(" -classpath " + classpath.asString());

•            munged.append(" -classpath ").append(classpath.asString());
         }
         return munged.toString();
     } else {

diff --git a/src/share/classes/com/sun/security/sasl/CramMD5Base.java b/src/share/classes/com/sun/security/sasl/CramMD5Base.java --- a/src/share/classes/com/sun/security/sasl/CramMD5Base.java +++ b/src/share/classes/com/sun/security/sasl/CramMD5Base.java @@ -199,8 +199,7 @@

     for (i = 0; i < digest.length; i++) {
         if ((digest[i] & 0x000000ff) < 0x10) {

•            digestString.append("0" +

•                Integer.toHexString(digest[i] & 0x000000ff));

• digestString.append("0").append(Integer.toHexString(digest[i] & 0x000000ff)); } else { digestString.append( Integer.toHexString(digest[i] & 0x000000ff));

diff --git a/src/share/classes/com/sun/jndi/ldap/sasl/DefaultCallbackHandler.java b/src/share/classes/com/sun/jndi/ldap/sasl/DefaultCallbackHandler.java --- a/src/share/classes/com/sun/jndi/ldap/sasl/DefaultCallbackHandler.java +++ b/src/share/classes/com/sun/jndi/ldap/sasl/DefaultCallbackHandler.java @@ -90,7 +90,7 @@ if (selected == -1) { StringBuffer allChoices = new StringBuffer(); for (int j = 0; j < choices.length; j++) {

•                            allChoices.append(choices[j] + ",");

•                            allChoices.append(choices[j]).append(',');
                         }
                         throw new IOException("Cannot match " +
                             "'java.naming.security.sasl.realm'

property value, '" +

diff --git a/src/share/classes/com/sun/security/sasl/digest/DigestMD5Base.java b/src/share/classes/com/sun/security/sasl/digest/DigestMD5Base.java --- a/src/share/classes/com/sun/security/sasl/digest/DigestMD5Base.java +++ b/src/share/classes/com/sun/security/sasl/digest/DigestMD5Base.java @@ -391,7 +391,7 @@

     for (int i = 0; i < digest.length; i ++) {
         if ((digest[i] & 0x000000ff) < 0x10) {

•            digestString.append("0"+

•            digestString.append("0").append(
                 Integer.toHexString(digest[i] & 0x000000ff));
         } else {
             digestString.append(

diff --git a/src/share/classes/com/sun/tools/hat/internal/model/JavaValueArray.java b/src/share/classes/com/sun/tools/hat/internal/model/JavaValueArray.java --- a/src/share/classes/com/sun/tools/hat/internal/model/JavaValueArray.java +++ b/src/share/classes/com/sun/tools/hat/internal/model/JavaValueArray.java @@ -386,37 +386,37 @@ } case 'B': { int val = 0xFF & byteAt(i, value);

•                    result.append("0x" + Integer.toString(val, 16));

•                    result.append("0x").append(Integer.toString(val,

16)); i++; break; } case 'S': { short val = shortAt(i, value); i += 2;

•                    result.append("" + val);

•                    result.append("").append(val);
                     break;
                 }
                 case 'I': {
                     int val = intAt(i, value);
                     i += 4;

•                    result.append("" + val);

•                    result.append("").append( val);
                     break;
                 }
                 case 'J': {         // long
                     long val = longAt(i, value);

•                    result.append("" + val);

•                    result.append("").append(val);
                     i += 8;
                     break;
                 }
                 case 'F': {
                     float val = floatAt(i, value);

•                    result.append("" + val);

•                    result.append("").append(val);
                     i += 4;
                     break;
                 }
                 case 'D': {         // double
                     double val = doubleAt(i, value);

•                    result.append("" + val);

•                    result.append("").append(val);
                     i += 8;
                     break;
                 }

diff --git a/src/share/classes/com/sun/jmx/snmp/IPAcl/NetMaskImpl.java b/src/share/classes/com/sun/jmx/snmp/IPAcl/NetMaskImpl.java --- a/src/share/classes/com/sun/jmx/snmp/IPAcl/NetMaskImpl.java +++ b/src/share/classes/com/sun/jmx/snmp/IPAcl/NetMaskImpl.java @@ -65,7 +65,7 @@ "extractSubNet", "BINARY ARRAY :"); StringBuffer buff = new StringBuffer(); for(int i =0; i < addrLength; i++) {

•            buff.append((b[i] &0xFF) +":");

•            buff.append((b[i] &0xFF)).append(":");
         }
         SNMP_LOGGER.logp(Level.FINEST, NetMaskImpl.class.getName(),
             "extractSubNet", buff.toString());

diff --git a/src/share/classes/com/sun/org/apache/xml/internal/security/utils/RFC2253Parser.java b/src/share/classes/com/sun/org/apache/xml/internal/security/utils/RFC2253Parser.java

a/src/share/classes/com/sun/org/apache/xml/internal/security/utils/RFC2253Parser.java +++ b/src/share/classes/com/sun/org/apache/xml/internal/security/utils/RFC2253Parser.java @@ -98,7 +98,7 @@ l += countQuotes(_DN, j, k);

         if ((k > 0) && (_DN.charAt(k - 1) != '\\') && (l % 2) != 1) {

•           sb.append(parseRDN(_DN.substring(i, k).trim()) + ",");

•           sb.append(parseRDN(_DN.substring(i, k).trim())).append(',');
  
            i = k + 1;
            l = 0;

@@ -131,8 +131,7 @@ l += countQuotes(str, j, k);

      if ((k > 0) && (str.charAt(k - 1) != '\\') && (l % 2) != 1) {

•        sb.append(parseATAV(trim(str.substring(i, k))) + "+");

•        sb.append(parseATAV(trim(str.substring(i, k)))).append("+");
         i = k + 1;
         l = 0;
      }

@@ -386,7 +385,7 @@ int k;

   for (int j = 0; (k = string.indexOf("\\20", j)) >= 0; j = k + 3) {

•     sb.append(trim(string.substring(i, k)) + "\\ ");

•     sb.append(trim(string.substring(i, k))).append("\\ ");
  
      i = k + 3;
   }

@@ -436,7 +435,7 @@ l += countQuotes(str, j, k);

      if ((k > 0) && (str.charAt(k - 1) != '\\') && (l % 2) != 1) {

•        sb.append(trim(str.substring(i, k)) + replace);

•        sb.append(trim(str.substring(i, k))).append(replace);
  
         i = k + 1;
         l = 0;

diff --git a/src/share/classes/com/sun/tools/example/debug/gui/ContextManager.java b/src/share/classes/com/sun/tools/example/debug/gui/ContextManager.java --- a/src/share/classes/com/sun/tools/example/debug/gui/ContextManager.java +++ b/src/share/classes/com/sun/tools/example/debug/gui/ContextManager.java @@ -338,10 +338,10 @@ if (classpath.isEmpty()) { String envcp = System.getProperty("env.class.path"); if ((envcp != null) && (envcp.length() > 0)) {

•                munged.append(" -classpath " + envcp);

•                munged.append(" -classpath ").append(envcp);
             }
         } else {

•            munged.append(" -classpath " + classpath.asString());

•            munged.append(" -classpath ").append(classpath.asString());
         }
         return munged.toString();
     } else {

diff --git a/src/share/classes/com/sun/security/sasl/CramMD5Base.java b/src/share/classes/com/sun/security/sasl/CramMD5Base.java --- a/src/share/classes/com/sun/security/sasl/CramMD5Base.java +++ b/src/share/classes/com/sun/security/sasl/CramMD5Base.java @@ -199,8 +199,7 @@

     for (i = 0; i < digest.length; i++) {
         if ((digest[i] & 0x000000ff) < 0x10) {

•            digestString.append("0" +

•                Integer.toHexString(digest[i] & 0x000000ff));

• digestString.append("0").append(Integer.toHexString(digest[i] & 0x000000ff)); } else { digestString.append( Integer.toHexString(digest[i] & 0x000000ff));

diff --git a/src/share/classes/com/sun/jndi/ldap/sasl/DefaultCallbackHandler.java b/src/share/classes/com/sun/jndi/ldap/sasl/DefaultCallbackHandler.java --- a/src/share/classes/com/sun/jndi/ldap/sasl/DefaultCallbackHandler.java +++ b/src/share/classes/com/sun/jndi/ldap/sasl/DefaultCallbackHandler.java @@ -90,7 +90,7 @@ if (selected == -1) { StringBuffer allChoices = new StringBuffer(); for (int j = 0; j < choices.length; j++) {

•                            allChoices.append(choices[j] + ",");

•                            allChoices.append(choices[j]).append(',');
                         }
                         throw new IOException("Cannot match " +
                             "'java.naming.security.sasl.realm'

property value, '" +

diff --git a/src/share/classes/com/sun/security/sasl/digest/DigestMD5Base.java b/src/share/classes/com/sun/security/sasl/digest/DigestMD5Base.java --- a/src/share/classes/com/sun/security/sasl/digest/DigestMD5Base.java +++ b/src/share/classes/com/sun/security/sasl/digest/DigestMD5Base.java @@ -391,7 +391,7 @@

     for (int i = 0; i < digest.length; i ++) {
         if ((digest[i] & 0x000000ff) < 0x10) {

•            digestString.append("0"+

•            digestString.append("0").append(
                 Integer.toHexString(digest[i] & 0x000000ff));
         } else {
             digestString.append(

diff --git a/src/share/classes/com/sun/tools/hat/internal/model/JavaValueArray.java b/src/share/classes/com/sun/tools/hat/internal/model/JavaValueArray.java --- a/src/share/classes/com/sun/tools/hat/internal/model/JavaValueArray.java +++ b/src/share/classes/com/sun/tools/hat/internal/model/JavaValueArray.java @@ -386,37 +386,37 @@ } case 'B': { int val = 0xFF & byteAt(i, value);

•                    result.append("0x" + Integer.toString(val, 16));

•                    result.append("0x").append(Integer.toString(val,

16)); i++; break; } case 'S': { short val = shortAt(i, value); i += 2;

•                    result.append("" + val);

•                    result.append("").append(val);
                     break;
                 }
                 case 'I': {
                     int val = intAt(i, value);
                     i += 4;

•                    result.append("" + val);

•                    result.append("").append( val);
                     break;
                 }
                 case 'J': {         // long
                     long val = longAt(i, value);

•                    result.append("" + val);

•                    result.append("").append(val);
                     i += 8;
                     break;
                 }
                 case 'F': {
                     float val = floatAt(i, value);

•                    result.append("" + val);

•                    result.append("").append(val);
                     i += 4;
                     break;
                 }
                 case 'D': {         // double
                     double val = doubleAt(i, value);

•                    result.append("" + val);

•                    result.append("").append(val);
                     i += 8;
                     break;
                 }

diff --git a/src/share/classes/com/sun/jmx/snmp/IPAcl/NetMaskImpl.java b/src/share/classes/com/sun/jmx/snmp/IPAcl/NetMaskImpl.java --- a/src/share/classes/com/sun/jmx/snmp/IPAcl/NetMaskImpl.java +++ b/src/share/classes/com/sun/jmx/snmp/IPAcl/NetMaskImpl.java @@ -65,7 +65,7 @@ "extractSubNet", "BINARY ARRAY :"); StringBuffer buff = new StringBuffer(); for(int i =0; i < addrLength; i++) {

•            buff.append((b[i] &0xFF) +":");

•            buff.append((b[i] &0xFF)).append(":");
         }
         SNMP_LOGGER.logp(Level.FINEST, NetMaskImpl.class.getName(),
             "extractSubNet", buff.toString());

diff --git a/src/share/classes/com/sun/org/apache/xml/internal/security/utils/RFC2253Parser.java b/src/share/classes/com/sun/org/apache/xml/internal/security/utils/RFC2253Parser.java

a/src/share/classes/com/sun/org/apache/xml/internal/security/utils/RFC2253Parser.java +++ b/src/share/classes/com/sun/org/apache/xml/internal/security/utils/RFC2253Parser.java @@ -98,7 +98,7 @@ l += countQuotes(_DN, j, k);

         if ((k > 0) && (_DN.charAt(k - 1) != '\\') && (l % 2) != 1) {

•           sb.append(parseRDN(_DN.substring(i, k).trim()) + ",");

•           sb.append(parseRDN(_DN.substring(i, k).trim())).append(',');
  
            i = k + 1;
            l = 0;

@@ -131,8 +131,7 @@ l += countQuotes(str, j, k);

      if ((k > 0) && (str.charAt(k - 1) != '\\') && (l % 2) != 1) {

•        sb.append(parseATAV(trim(str.substring(i, k))) + "+");

•        sb.append(parseATAV(trim(str.substring(i, k)))).append("+");
         i = k + 1;
         l = 0;
      }

@@ -386,7 +385,7 @@ int k;

   for (int j = 0; (k = string.indexOf("\\20", j)) >= 0; j = k + 3) {

•     sb.append(trim(string.substring(i, k)) + "\\ ");

•     sb.append(trim(string.substring(i, k))).append("\\ ");
  
      i = k + 3;
   }

@@ -436,7 +435,7 @@ l += countQuotes(str, j, k);

      if ((k > 0) && (str.charAt(k - 1) != '\\') && (l % 2) != 1) {

•        sb.append(trim(str.substring(i, k)) + replace);

•        sb.append(trim(str.substring(i, k))).append(replace);
  
         i = k + 1;
         l = 0;

diff --git a/src/share/classes/com/sun/tools/example/debug/gui/ContextManager.java b/src/share/classes/com/sun/tools/example/debug/gui/ContextManager.java --- a/src/share/classes/com/sun/tools/example/debug/gui/ContextManager.java +++ b/src/share/classes/com/sun/tools/example/debug/gui/ContextManager.java @@ -338,10 +338,10 @@ if (classpath.isEmpty()) { String envcp = System.getProperty("env.class.path"); if ((envcp != null) && (envcp.length() > 0)) {

•                munged.append(" -classpath " + envcp);

•                munged.append(" -classpath ").append(envcp);
             }
         } else {

•            munged.append(" -classpath " + classpath.asString());

•            munged.append(" -classpath ").append(classpath.asString());
         }
         return munged.toString();
     } else {

diff --git a/src/share/classes/com/sun/security/sasl/CramMD5Base.java b/src/share/classes/com/sun/security/sasl/CramMD5Base.java --- a/src/share/classes/com/sun/security/sasl/CramMD5Base.java +++ b/src/share/classes/com/sun/security/sasl/CramMD5Base.java @@ -199,8 +199,7 @@

     for (i = 0; i < digest.length; i++) {
         if ((digest[i] & 0x000000ff) < 0x10) {

•            digestString.append("0" +

•                Integer.toHexString(digest[i] & 0x000000ff));

• digestString.append("0").append(Integer.toHexString(digest[i] & 0x000000ff)); } else { digestString.append( Integer.toHexString(digest[i] & 0x000000ff)); diff --git

a/src/share/classes/com/sun/jndi/ldap/sasl/DefaultCallbackHandler.java b/src/share/classes/com/sun/jndi/ldap/sasl/DefaultCallbackHandler.java --- a/src/share/classes/com/sun/jndi/ldap/sasl/DefaultCallbackHandler.java +++ b/src/share/classes/com/sun/jndi/ldap/sasl/DefaultCallbackHandler.java @@ -90,7 +90,7 @@ if (selected == -1) { StringBuffer allChoices = new StringBuffer(); for (int j = 0; j < choices.length; j++) {

•                            allChoices.append(choices[j] + ",");

•                            allChoices.append(choices[j]).append(',');
                         }
                         throw new IOException("Cannot match " +
                             "'java.naming.security.sasl.realm'

property value, '" +

diff --git a/src/share/classes/com/sun/security/sasl/digest/DigestMD5Base.java b/src/share/classes/com/sun/security/sasl/digest/DigestMD5Base.java --- a/src/share/classes/com/sun/security/sasl/digest/DigestMD5Base.java +++ b/src/share/classes/com/sun/security/sasl/digest/DigestMD5Base.java @@ -391,7 +391,7 @@

     for (int i = 0; i < digest.length; i ++) {
         if ((digest[i] & 0x000000ff) < 0x10) {

•            digestString.append("0"+

•            digestString.append("0").append(
                 Integer.toHexString(digest[i] & 0x000000ff));
         } else {
             digestString.append(

diff --git a/src/share/classes/com/sun/tools/hat/internal/model/JavaValueArray.java b/src/share/classes/com/sun/tools/hat/internal/model/JavaValueArray.java --- a/src/share/classes/com/sun/tools/hat/internal/model/JavaValueArray.java +++ b/src/share/classes/com/sun/tools/hat/internal/model/JavaValueArray.java @@ -386,37 +386,37 @@ } case 'B': { int val = 0xFF & byteAt(i, value);

•                    result.append("0x" + Integer.toString(val, 16));

•                    result.append("0x").append(Integer.toString(val,

16)); i++; break; } case 'S': { short val = shortAt(i, value); i += 2;

•                    result.append("" + val);

•                    result.append("").append(val);
                     break;
                 }
                 case 'I': {
                     int val = intAt(i, value);
                     i += 4;

•                    result.append("" + val);

•                    result.append("").append( val);
                     break;
                 }
                 case 'J': {         // long
                     long val = longAt(i, value);

•                    result.append("" + val);

•                    result.append("").append(val);
                     i += 8;
                     break;
                 }
                 case 'F': {
                     float val = floatAt(i, value);

•                    result.append("" + val);

•                    result.append("").append(val);
                     i += 4;
                     break;
                 }
                 case 'D': {         // double
                     double val = doubleAt(i, value);

•                    result.append("" + val);

•                    result.append("").append(val);
                     i += 8;
                     break;
                 }

diff --git a/src/share/classes/com/sun/jmx/snmp/IPAcl/NetMaskImpl.java b/src/share/classes/com/sun/jmx/snmp/IPAcl/NetMaskImpl.java --- a/src/share/classes/com/sun/jmx/snmp/IPAcl/NetMaskImpl.java +++ b/src/share/classes/com/sun/jmx/snmp/IPAcl/NetMaskImpl.java @@ -65,7 +65,7 @@ "extractSubNet", "BINARY ARRAY :"); StringBuffer buff = new StringBuffer(); for(int i =0; i < addrLength; i++) {

•            buff.append((b[i] &0xFF) +":");

•            buff.append((b[i] &0xFF)).append(":");
         }
         SNMP_LOGGER.logp(Level.FINEST, NetMaskImpl.class.getName(),
             "extractSubNet", buff.toString());

diff --git a/src/share/classes/com/sun/org/apache/xml/internal/security/utils/RFC2253Parser.java b/src/share/classes/com/sun/org/apache/xml/internal/security/utils/RFC2253Parser.java

a/src/share/classes/com/sun/org/apache/xml/internal/security/utils/RFC2253Parser.java +++ b/src/share/classes/com/sun/org/apache/xml/internal/security/utils/RFC2253Parser.java @@ -98,7 +98,7 @@ l += countQuotes(_DN, j, k);

         if ((k > 0) && (_DN.charAt(k - 1) != '\\') && (l % 2) != 1) {

•           sb.append(parseRDN(_DN.substring(i, k).trim()) + ",");

•           sb.append(parseRDN(_DN.substring(i, k).trim())).append(',');
  
            i = k + 1;
            l = 0;

@@ -131,8 +131,7 @@ l += countQuotes(str, j, k);

      if ((k > 0) && (str.charAt(k - 1) != '\\') && (l % 2) != 1) {

•        sb.append(parseATAV(trim(str.substring(i, k))) + "+");

•        sb.append(parseATAV(trim(str.substring(i, k)))).append("+");
         i = k + 1;
         l = 0;
      }

@@ -386,7 +385,7 @@ int k;

   for (int j = 0; (k = string.indexOf("\\20", j)) >= 0; j = k + 3) {

•     sb.append(trim(string.substring(i, k)) + "\\ ");

•     sb.append(trim(string.substring(i, k))).append("\\ ");
  
      i = k + 3;
   }

@@ -436,7 +435,7 @@ l += countQuotes(str, j, k);

      if ((k > 0) && (str.charAt(k - 1) != '\\') && (l % 2) != 1) {

•        sb.append(trim(str.substring(i, k)) + replace);

•        sb.append(trim(str.substring(i, k))).append(replace);
  
         i = k + 1;
         l = 0;

diff --git a/src/share/classes/com/sun/tools/jdi/VirtualMachineImpl.java b/src/share/classes/com/sun/tools/jdi/VirtualMachineImpl.java --- a/src/share/classes/com/sun/tools/jdi/VirtualMachineImpl.java +++ b/src/share/classes/com/sun/tools/jdi/VirtualMachineImpl.java @@ -881,10 +881,10 @@ } else if (tag == JDWP.TypeTag.ARRAY) { sb.append("ArrayType"); } else {

•            sb.append("UNKNOWN TAG: " + tag);

•            sb.append("UNKNOWN TAG: ").append(tag);
         }
         if (signature != null) {

•            sb.append(", signature='" + signature + "'");

•            sb.append(", signature='").append(signature).append("'");
         }
         sb.append(", id=" + id);
         vm.printTrace(sb.toString());

diff --git a/src/share/classes/com/sun/media/sound/WaveExtensibleFileReader.java b/src/share/classes/com/sun/media/sound/WaveExtensibleFileReader.java --- a/src/share/classes/com/sun/media/sound/WaveExtensibleFileReader.java +++ b/src/share/classes/com/sun/media/sound/WaveExtensibleFileReader.java @@ -167,9 +167,9 @@ for (int i = 0; i < allchannelnames.length; i++) { if ((channelmask & m) != 0L) { if (i < channelnames.length) {

•                sb.append(channelnames[i] + " ");

•                sb.append(channelnames[i]).append(" ");
             } else {

•                sb.append(allchannelnames[i] + " ");

•                sb.append(allchannelnames[i]).append(" ");
             }
         }
         m *= 2L;

diff --git a/src/share/classes/com/sun/org/apache/xml/internal/security/encryption/XMLCipher.java b/src/share/classes/com/sun/org/apache/xml/internal/security/encryption/XMLCipher.java

a/src/share/classes/com/sun/org/apache/xml/internal/security/encryption/XMLCipher.java +++ b/src/share/classes/com/sun/org/apache/xml/internal/security/encryption/XMLCipher.java @@ -1932,7 +1932,7 @@ StringBuffer sb;

                     sb = new StringBuffer();

•                    sb.append("<?xml version=\"1.0\"

encoding="UTF-8"?><"+tagname);

•                    sb.append("<?xml version=\"1.0\"

encoding="UTF-8"?><").append(tagname);

                     // Run through each node up to the document node

and find any // xmlns: nodes

diff --git a/src/share/classes/com/sun/tools/jdi/VirtualMachineImpl.java b/src/share/classes/com/sun/tools/jdi/VirtualMachineImpl.java --- a/src/share/classes/com/sun/tools/jdi/VirtualMachineImpl.java +++ b/src/share/classes/com/sun/tools/jdi/VirtualMachineImpl.java @@ -881,10 +881,10 @@ } else if (tag == JDWP.TypeTag.ARRAY) { sb.append("ArrayType"); } else {

•            sb.append("UNKNOWN TAG: " + tag);

•            sb.append("UNKNOWN TAG: ").append(tag);
         }
         if (signature != null) {

•            sb.append(", signature='" + signature + "'");

•            sb.append(", signature='").append(signature).append("'");
         }
         sb.append(", id=" + id);
         vm.printTrace(sb.toString());

diff --git a/src/share/classes/com/sun/media/sound/WaveExtensibleFileReader.java b/src/share/classes/com/sun/media/sound/WaveExtensibleFileReader.java --- a/src/share/classes/com/sun/media/sound/WaveExtensibleFileReader.java +++ b/src/share/classes/com/sun/media/sound/WaveExtensibleFileReader.java @@ -167,9 +167,9 @@ for (int i = 0; i < allchannelnames.length; i++) { if ((channelmask & m) != 0L) { if (i < channelnames.length) {

•                sb.append(channelnames[i] + " ");

•                sb.append(channelnames[i]).append(" ");
             } else {

•                sb.append(allchannelnames[i] + " ");

•                sb.append(allchannelnames[i]).append(" ");
             }
         }
         m *= 2L;

diff --git a/src/share/classes/com/sun/org/apache/xml/internal/security/encryption/XMLCipher.java b/src/share/classes/com/sun/org/apache/xml/internal/security/encryption/XMLCipher.java

a/src/share/classes/com/sun/org/apache/xml/internal/security/encryption/XMLCipher.java +++ b/src/share/classes/com/sun/org/apache/xml/internal/security/encryption/XMLCipher.java @@ -1932,7 +1932,7 @@ StringBuffer sb;

                     sb = new StringBuffer();

•                    sb.append("<?xml version=\"1.0\"

encoding="UTF-8"?><"+tagname);

•                    sb.append("<?xml version=\"1.0\"

encoding="UTF-8"?><").append(tagname);

                     // Run through each node up to the document node

and find any // xmlns: nodes

diff --git a/src/share/classes/com/sun/tools/jdi/VirtualMachineImpl.java b/src/share/classes/com/sun/tools/jdi/VirtualMachineImpl.java --- a/src/share/classes/com/sun/tools/jdi/VirtualMachineImpl.java +++ b/src/share/classes/com/sun/tools/jdi/VirtualMachineImpl.java @@ -881,10 +881,10 @@ } else if (tag == JDWP.TypeTag.ARRAY) { sb.append("ArrayType"); } else {

•            sb.append("UNKNOWN TAG: " + tag);

•            sb.append("UNKNOWN TAG: ").append(tag);
         }
         if (signature != null) {

•            sb.append(", signature='" + signature + "'");

•            sb.append(", signature='").append(signature).append("'");
         }
         sb.append(", id=" + id);
         vm.printTrace(sb.toString());

diff --git a/src/share/classes/com/sun/media/sound/WaveExtensibleFileReader.java b/src/share/classes/com/sun/media/sound/WaveExtensibleFileReader.java --- a/src/share/classes/com/sun/media/sound/WaveExtensibleFileReader.java +++ b/src/share/classes/com/sun/media/sound/WaveExtensibleFileReader.java @@ -167,9 +167,9 @@ for (int i = 0; i < allchannelnames.length; i++) { if ((channelmask & m) != 0L) { if (i < channelnames.length) {

•                sb.append(channelnames[i] + " ");

•                sb.append(channelnames[i]).append(" ");
             } else {

•                sb.append(allchannelnames[i] + " ");

•                sb.append(allchannelnames[i]).append(" ");
             }
         }
         m *= 2L;

diff --git a/src/share/classes/com/sun/org/apache/xml/internal/security/encryption/XMLCipher.java b/src/share/classes/com/sun/org/apache/xml/internal/security/encryption/XMLCipher.java

a/src/share/classes/com/sun/org/apache/xml/internal/security/encryption/XMLCipher.java +++ b/src/share/classes/com/sun/org/apache/xml/internal/security/encryption/XMLCipher.java @@ -1932,7 +1932,7 @@ StringBuffer sb;

                     sb = new StringBuffer();

•                    sb.append("<?xml version=\"1.0\"

encoding="UTF-8"?><"+tagname);

•                    sb.append("<?xml version=\"1.0\"

encoding="UTF-8"?><").append(tagname);

                     // Run through each node up to the document node

and find any // xmlns: nodes

-- java_lang

diff --git a/src/share/classes/java/lang/invoke/LambdaForm.java b/src/share/classes/java/lang/invoke/LambdaForm.java --- a/src/share/classes/java/lang/invoke/LambdaForm.java +++ b/src/share/classes/java/lang/invoke/LambdaForm.java @@ -708,7 +708,7 @@ }

 public String toString() {

•    StringBuilder buf = new StringBuilder(debugName+"=Lambda(");

•    StringBuilder buf = new

StringBuilder(debugName).append("=Lambda("); for (int i = 0; i < names.length; i++) { if (i == arity) buf.append(")=>{"); Name n = names[i];

-- Atenciosamente.

Otávio Gonçalves de Santana

blog: http://otaviosantana.blogspot.com.br/ twitter: http://twitter.com/otaviojava site: http://www.otaviojava.com.br (11) 98255-3513

• Previous message: RFR (S) CR 7177472: JSR292: MethodType interning penalizes scalability
• Next message: Inefficient use StringBuffer or StringBuilder[Optimization|clean-up] {Package: con.sun. * java.lang*}
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the core-libs-dev mailing list