Re: Inefficient use StringBuffer or StringBuilder[Optimization|clean-up] {Package: con.sun. * java.lang*} (original) (raw)

Victor Polischuk victor2 at ukr.net
Fri Jun 7 20:42:15 UTC 2013

Excuse me for asking something stupid but do empty appends in "com.sun.tools.hat.internal.model.JavaValueArray" make any sense?

result.append("").append(val);

//Victor

--- Original message --- From: "Otávio Gonçalves de Santana" <otaviojava at java.net> Date: 7 June 2013, 16:20:02

Inefficient use StringBuffer or StringBuilder[Optimization|clean-up]

The string addition in the parameter will create another string buffer, append all the components, then convert that to a string so the you can be appended to your string buffer. So I replace this: sb.append(" xxx: [" + getXXX() + "]\n"); for this: sb.append(" xxx: [").append(getXXX()).append("]\n"); The classes are: -- com.sun com.sun.tools.hat.internal.model.JavaValueArray com.sun.jmx.snmp.IPAcl.NetMaskImpl com.sun.jndi.ldap.sasl.DefaultCallbackHandler com.sun.media.sound.WaveExtensibleFileReader com.sun.org.apache.xml.internal.security.encryption.XMLCipher com.sun.org.apache.xml.internal.security.utils.RFC2253Parser com.sun.security.sasl.CramMD5Base com.sun.security.sasl.digest.DigestMD5Base com.sun.tools.example.debug.gui.ContextManager com.sun.tools.jdi.VirtualMachineImpl -- java.lang java.lang.invoke.LambdaForm

The diff bellow: diff --git a/src/share/classes/com/sun/tools/example/debug/gui/ContextManager.java b/src/share/classes/com/sun/tools/example/debug/gui/ContextManager.java --- a/src/share/classes/com/sun/tools/example/debug/gui/ContextManager.java +++ b/src/share/classes/com/sun/tools/example/debug/gui/ContextManager.java @@ -338,10 +338,10 @@ if (classpath.isEmpty()) { String envcp = System.getProperty("env.class.path"); if ((envcp != null) && (envcp.length() > 0)) { - munged.append(" -classpath " + envcp); + munged.append(" -classpath ").append(envcp); } } else { - munged.append(" -classpath " + classpath.asString()); + munged.append(" -classpath ").append(classpath.asString()); } return munged.toString(); } else {

diff --git a/src/share/classes/com/sun/security/sasl/CramMD5Base.java b/src/share/classes/com/sun/security/sasl/CramMD5Base.java --- a/src/share/classes/com/sun/security/sasl/CramMD5Base.java +++ b/src/share/classes/com/sun/security/sasl/CramMD5Base.java @@ -199,8 +199,7 @@ for (i = 0; i < digest.length; i++) {_ _if ((digest[i] & 0x000000ff) < 0x10) {_ _- digestString.append("0" +_ _- Integer.toHexString(digest[i] & 0x000000ff));_ _+_ _digestString.append("0").append(Integer.toHexString(digest[i] &_ _0x000000ff));_ _} else {_ _digestString.append(_ _Integer.toHexString(digest[i] & 0x000000ff));_ _diff --git_ _a/src/share/classes/com/sun/jndi/ldap/sasl/DefaultCallbackHandler.java_ _b/src/share/classes/com/sun/jndi/ldap/sasl/DefaultCallbackHandler.java_ _--- a/src/share/classes/com/sun/jndi/ldap/sasl/DefaultCallbackHandler.java_ _+++ b/src/share/classes/com/sun/jndi/ldap/sasl/DefaultCallbackHandler.java_ _@@ -90,7 +90,7 @@_ _if (selected == -1) {_ _StringBuffer allChoices = new StringBuffer();_ _for (int j = 0; j < choices.length; j++) {_ _- allChoices.append(choices[j] + ",");_ _+ allChoices.append(choices[j]).append(',');_ _}_ _throw new IOException("Cannot match " +_ _"'java.naming.security.sasl.realm'_ _property value, '" +_ _diff --git_ _a/src/share/classes/com/sun/security/sasl/digest/DigestMD5Base.java_ _b/src/share/classes/com/sun/security/sasl/digest/DigestMD5Base.java_ _--- a/src/share/classes/com/sun/security/sasl/digest/DigestMD5Base.java_ _+++ b/src/share/classes/com/sun/security/sasl/digest/DigestMD5Base.java_ _@@ -391,7 +391,7 @@_ _for (int i = 0; i < digest.length; i ++) {_ _if ((digest[i] & 0x000000ff) < 0x10) {_ _- digestString.append("0"+_ _+ digestString.append("0").append(_ _Integer.toHexString(digest[i] & 0x000000ff));_ _} else {_ _digestString.append(_ _diff --git_ _a/src/share/classes/com/sun/tools/hat/internal/model/JavaValueArray.java_ _b/src/share/classes/com/sun/tools/hat/internal/model/JavaValueArray.java_ _--- a/src/share/classes/com/sun/tools/hat/internal/model/JavaValueArray.java_ _+++ b/src/share/classes/com/sun/tools/hat/internal/model/JavaValueArray.java_ _@@ -386,37 +386,37 @@_ _}_ _case 'B': {_ _int val = 0xFF & byteAt(i, value);_ _- result.append("0x" + Integer.toString(val, 16));_ _+ result.append("0x").append(Integer.toString(val,_ _16));_ _i++;_ _break;_ _}_ _case 'S': {_ _short val = shortAt(i, value);_ _i += 2;_ _- result.append("" + val);_ _+ result.append("").append(val);_ _break;_ _}_ _case 'I': {_ _int val = intAt(i, value);_ _i += 4;_ _- result.append("" + val);_ _+ result.append("").append( val);_ _break;_ _}_ _case 'J': { // long_ _long val = longAt(i, value);_ _- result.append("" + val);_ _+ result.append("").append(val);_ _i += 8;_ _break;_ _}_ _case 'F': {_ _float val = floatAt(i, value);_ _- result.append("" + val);_ _+ result.append("").append(val);_ _i += 4;_ _break;_ _}_ _case 'D': { // double_ _double val = doubleAt(i, value);_ _- result.append("" + val);_ _+ result.append("").append(val);_ _i += 8;_ _break;_ _}_ _diff --git a/src/share/classes/com/sun/jmx/snmp/IPAcl/NetMaskImpl.java_ _b/src/share/classes/com/sun/jmx/snmp/IPAcl/NetMaskImpl.java_ _--- a/src/share/classes/com/sun/jmx/snmp/IPAcl/NetMaskImpl.java_ _+++ b/src/share/classes/com/sun/jmx/snmp/IPAcl/NetMaskImpl.java_ _@@ -65,7 +65,7 @@_ _"extractSubNet", "BINARY ARRAY :");_ _StringBuffer buff = new StringBuffer();_ _for(int i =0; i < addrLength; i++) {_ _- buff.append((b[i] &0xFF) +":");_ _+ buff.append((b[i] &0xFF)).append(":");_ _}_ _SNMPLOGGER.logp(Level.FINEST, NetMaskImpl.class.getName(),_ _"extractSubNet", buff.toString());_ _diff --git_ _a/src/share/classes/com/sun/org/apache/xml/internal/security/utils/RFC2253Parser.java_ _b/src/share/classes/com/sun/org/apache/xml/internal/security/utils/RFC2253Parser.java_ _---_ _a/src/share/classes/com/sun/org/apache/xml/internal/security/utils/RFC2253Parser.java_ _+++_ _b/src/share/classes/com/sun/org/apache/xml/internal/security/utils/RFC2253Parser.java_ _@@ -98,7 +98,7 @@_ _l += countQuotes(DN, j, k);_ _if ((k > 0) && (DN.charAt(k - 1) != '\') && (l % 2) != 1) { - sb.append(parseRDN(DN.substring(i, k).trim()) + ","); + sb.append(parseRDN(DN.substring(i, k).trim())).append(','); i = k + 1; l = 0; @@ -131,8 +131,7 @@ l += countQuotes(str, j, k); if ((k > 0) && (str.charAt(k - 1) != '\') && (l % 2) != 1) { - sb.append(parseATAV(trim(str.substring(i, k))) + "+"); - + sb.append(parseATAV(trim(str.substring(i, k)))).append("+"); i = k + 1; l = 0; } @@ -386,7 +385,7 @@ int k; for (int j = 0; (k = string.indexOf("\20", j)) >= 0; j = k + 3) { - sb.append(trim(string.substring(i, k)) + "\ "); + sb.append(trim(string.substring(i, k))).append("\ "); i = k + 3; } @@ -436,7 +435,7 @@ l += countQuotes(str, j, k); if ((k > 0) && (str.charAt(k - 1) != '\') && (l % 2) != 1) { - sb.append(trim(str.substring(i, k)) + replace); + sb.append(trim(str.substring(i, k))).append(replace); i = k + 1; l = 0; diff --git a/src/share/classes/com/sun/tools/example/debug/gui/ContextManager.java b/src/share/classes/com/sun/tools/example/debug/gui/ContextManager.java --- a/src/share/classes/com/sun/tools/example/debug/gui/ContextManager.java +++ b/src/share/classes/com/sun/tools/example/debug/gui/ContextManager.java @@ -338,10 +338,10 @@ if (classpath.isEmpty()) { String envcp = System.getProperty("env.class.path"); if ((envcp != null) && (envcp.length() > 0)) { - munged.append(" -classpath " + envcp); + munged.append(" -classpath ").append(envcp); } } else { - munged.append(" -classpath " + classpath.asString()); + munged.append(" -classpath ").append(classpath.asString()); } return munged.toString(); } else { diff --git a/src/share/classes/com/sun/security/sasl/CramMD5Base.java b/src/share/classes/com/sun/security/sasl/CramMD5Base.java --- a/src/share/classes/com/sun/security/sasl/CramMD5Base.java +++ b/src/share/classes/com/sun/security/sasl/CramMD5Base.java @@ -199,8 +199,7 @@ for (i = 0; i < digest.length; i++) {_ _if ((digest[i] & 0x000000ff) < 0x10) {_ _- digestString.append("0" +_ _- Integer.toHexString(digest[i] & 0x000000ff));_ _+_ _digestString.append("0").append(Integer.toHexString(digest[i] &_ _0x000000ff));_ _} else {_ _digestString.append(_ _Integer.toHexString(digest[i] & 0x000000ff));_ _diff --git_ _a/src/share/classes/com/sun/jndi/ldap/sasl/DefaultCallbackHandler.java_ _b/src/share/classes/com/sun/jndi/ldap/sasl/DefaultCallbackHandler.java_ _--- a/src/share/classes/com/sun/jndi/ldap/sasl/DefaultCallbackHandler.java_ _+++ b/src/share/classes/com/sun/jndi/ldap/sasl/DefaultCallbackHandler.java_ _@@ -90,7 +90,7 @@_ _if (selected == -1) {_ _StringBuffer allChoices = new StringBuffer();_ _for (int j = 0; j < choices.length; j++) {_ _- allChoices.append(choices[j] + ",");_ _+ allChoices.append(choices[j]).append(',');_ _}_ _throw new IOException("Cannot match " +_ _"'java.naming.security.sasl.realm'_ _property value, '" +_ _diff --git_ _a/src/share/classes/com/sun/security/sasl/digest/DigestMD5Base.java_ _b/src/share/classes/com/sun/security/sasl/digest/DigestMD5Base.java_ _--- a/src/share/classes/com/sun/security/sasl/digest/DigestMD5Base.java_ _+++ b/src/share/classes/com/sun/security/sasl/digest/DigestMD5Base.java_ _@@ -391,7 +391,7 @@_ _for (int i = 0; i < digest.length; i ++) {_ _if ((digest[i] & 0x000000ff) < 0x10) {_ _- digestString.append("0"+_ _+ digestString.append("0").append(_ _Integer.toHexString(digest[i] & 0x000000ff));_ _} else {_ _digestString.append(_ _diff --git_ _a/src/share/classes/com/sun/tools/hat/internal/model/JavaValueArray.java_ _b/src/share/classes/com/sun/tools/hat/internal/model/JavaValueArray.java_ _--- a/src/share/classes/com/sun/tools/hat/internal/model/JavaValueArray.java_ _+++ b/src/share/classes/com/sun/tools/hat/internal/model/JavaValueArray.java_ _@@ -386,37 +386,37 @@_ _}_ _case 'B': {_ _int val = 0xFF & byteAt(i, value);_ _- result.append("0x" + Integer.toString(val, 16));_ _+ result.append("0x").append(Integer.toString(val,_ _16));_ _i++;_ _break;_ _}_ _case 'S': {_ _short val = shortAt(i, value);_ _i += 2;_ _- result.append("" + val);_ _+ result.append("").append(val);_ _break;_ _}_ _case 'I': {_ _int val = intAt(i, value);_ _i += 4;_ _- result.append("" + val);_ _+ result.append("").append( val);_ _break;_ _}_ _case 'J': { // long_ _long val = longAt(i, value);_ _- result.append("" + val);_ _+ result.append("").append(val);_ _i += 8;_ _break;_ _}_ _case 'F': {_ _float val = floatAt(i, value);_ _- result.append("" + val);_ _+ result.append("").append(val);_ _i += 4;_ _break;_ _}_ _case 'D': { // double_ _double val = doubleAt(i, value);_ _- result.append("" + val);_ _+ result.append("").append(val);_ _i += 8;_ _break;_ _}_ _diff --git a/src/share/classes/com/sun/jmx/snmp/IPAcl/NetMaskImpl.java_ _b/src/share/classes/com/sun/jmx/snmp/IPAcl/NetMaskImpl.java_ _--- a/src/share/classes/com/sun/jmx/snmp/IPAcl/NetMaskImpl.java_ _+++ b/src/share/classes/com/sun/jmx/snmp/IPAcl/NetMaskImpl.java_ _@@ -65,7 +65,7 @@_ _"extractSubNet", "BINARY ARRAY :");_ _StringBuffer buff = new StringBuffer();_ _for(int i =0; i < addrLength; i++) {_ _- buff.append((b[i] &0xFF) +":");_ _+ buff.append((b[i] &0xFF)).append(":");_ _}_ _SNMPLOGGER.logp(Level.FINEST, NetMaskImpl.class.getName(),_ _"extractSubNet", buff.toString());_ _diff --git_ _a/src/share/classes/com/sun/org/apache/xml/internal/security/utils/RFC2253Parser.java_ _b/src/share/classes/com/sun/org/apache/xml/internal/security/utils/RFC2253Parser.java_ _---_ _a/src/share/classes/com/sun/org/apache/xml/internal/security/utils/RFC2253Parser.java_ _+++_ _b/src/share/classes/com/sun/org/apache/xml/internal/security/utils/RFC2253Parser.java_ _@@ -98,7 +98,7 @@_ _l += countQuotes(DN, j, k);_ _if ((k > 0) && (DN.charAt(k - 1) != '\') && (l % 2) != 1) { - sb.append(parseRDN(DN.substring(i, k).trim()) + ","); + sb.append(parseRDN(DN.substring(i, k).trim())).append(','); i = k + 1; l = 0; @@ -131,8 +131,7 @@ l += countQuotes(str, j, k); if ((k > 0) && (str.charAt(k - 1) != '\') && (l % 2) != 1) { - sb.append(parseATAV(trim(str.substring(i, k))) + "+"); - + sb.append(parseATAV(trim(str.substring(i, k)))).append("+"); i = k + 1; l = 0; } @@ -386,7 +385,7 @@ int k; for (int j = 0; (k = string.indexOf("\20", j)) >= 0; j = k + 3) { - sb.append(trim(string.substring(i, k)) + "\ "); + sb.append(trim(string.substring(i, k))).append("\ "); i = k + 3; } @@ -436,7 +435,7 @@ l += countQuotes(str, j, k); if ((k > 0) && (str.charAt(k - 1) != '\') && (l % 2) != 1) { - sb.append(trim(str.substring(i, k)) + replace); + sb.append(trim(str.substring(i, k))).append(replace); i = k + 1; l = 0; diff --git a/src/share/classes/com/sun/tools/example/debug/gui/ContextManager.java b/src/share/classes/com/sun/tools/example/debug/gui/ContextManager.java --- a/src/share/classes/com/sun/tools/example/debug/gui/ContextManager.java +++ b/src/share/classes/com/sun/tools/example/debug/gui/ContextManager.java @@ -338,10 +338,10 @@ if (classpath.isEmpty()) { String envcp = System.getProperty("env.class.path"); if ((envcp != null) && (envcp.length() > 0)) { - munged.append(" -classpath " + envcp); + munged.append(" -classpath ").append(envcp); } } else { - munged.append(" -classpath " + classpath.asString()); + munged.append(" -classpath ").append(classpath.asString()); } return munged.toString(); } else { diff --git a/src/share/classes/com/sun/security/sasl/CramMD5Base.java b/src/share/classes/com/sun/security/sasl/CramMD5Base.java --- a/src/share/classes/com/sun/security/sasl/CramMD5Base.java +++ b/src/share/classes/com/sun/security/sasl/CramMD5Base.java @@ -199,8 +199,7 @@ for (i = 0; i < digest.length; i++) {_ _if ((digest[i] & 0x000000ff) < 0x10) {_ _- digestString.append("0" +_ _- Integer.toHexString(digest[i] & 0x000000ff));_ _+_ _digestString.append("0").append(Integer.toHexString(digest[i] &_ _0x000000ff));_ _} else {_ _digestString.append(_ _Integer.toHexString(digest[i] & 0x000000ff));_ _diff --git_ _a/src/share/classes/com/sun/jndi/ldap/sasl/DefaultCallbackHandler.java_ _b/src/share/classes/com/sun/jndi/ldap/sasl/DefaultCallbackHandler.java_ _--- a/src/share/classes/com/sun/jndi/ldap/sasl/DefaultCallbackHandler.java_ _+++ b/src/share/classes/com/sun/jndi/ldap/sasl/DefaultCallbackHandler.java_ _@@ -90,7 +90,7 @@_ _if (selected == -1) {_ _StringBuffer allChoices = new StringBuffer();_ _for (int j = 0; j < choices.length; j++) {_ _- allChoices.append(choices[j] + ",");_ _+ allChoices.append(choices[j]).append(',');_ _}_ _throw new IOException("Cannot match " +_ _"'java.naming.security.sasl.realm'_ _property value, '" +_ _diff --git_ _a/src/share/classes/com/sun/security/sasl/digest/DigestMD5Base.java_ _b/src/share/classes/com/sun/security/sasl/digest/DigestMD5Base.java_ _--- a/src/share/classes/com/sun/security/sasl/digest/DigestMD5Base.java_ _+++ b/src/share/classes/com/sun/security/sasl/digest/DigestMD5Base.java_ _@@ -391,7 +391,7 @@_ _for (int i = 0; i < digest.length; i ++) {_ _if ((digest[i] & 0x000000ff) < 0x10) {_ _- digestString.append("0"+_ _+ digestString.append("0").append(_ _Integer.toHexString(digest[i] & 0x000000ff));_ _} else {_ _digestString.append(_ _diff --git_ _a/src/share/classes/com/sun/tools/hat/internal/model/JavaValueArray.java_ _b/src/share/classes/com/sun/tools/hat/internal/model/JavaValueArray.java_ _--- a/src/share/classes/com/sun/tools/hat/internal/model/JavaValueArray.java_ _+++ b/src/share/classes/com/sun/tools/hat/internal/model/JavaValueArray.java_ _@@ -386,37 +386,37 @@_ _}_ _case 'B': {_ _int val = 0xFF & byteAt(i, value);_ _- result.append("0x" + Integer.toString(val, 16));_ _+ result.append("0x").append(Integer.toString(val,_ _16));_ _i++;_ _break;_ _}_ _case 'S': {_ _short val = shortAt(i, value);_ _i += 2;_ _- result.append("" + val);_ _+ result.append("").append(val);_ _break;_ _}_ _case 'I': {_ _int val = intAt(i, value);_ _i += 4;_ _- result.append("" + val);_ _+ result.append("").append( val);_ _break;_ _}_ _case 'J': { // long_ _long val = longAt(i, value);_ _- result.append("" + val);_ _+ result.append("").append(val);_ _i += 8;_ _break;_ _}_ _case 'F': {_ _float val = floatAt(i, value);_ _- result.append("" + val);_ _+ result.append("").append(val);_ _i += 4;_ _break;_ _}_ _case 'D': { // double_ _double val = doubleAt(i, value);_ _- result.append("" + val);_ _+ result.append("").append(val);_ _i += 8;_ _break;_ _}_ _diff --git a/src/share/classes/com/sun/jmx/snmp/IPAcl/NetMaskImpl.java_ _b/src/share/classes/com/sun/jmx/snmp/IPAcl/NetMaskImpl.java_ _--- a/src/share/classes/com/sun/jmx/snmp/IPAcl/NetMaskImpl.java_ _+++ b/src/share/classes/com/sun/jmx/snmp/IPAcl/NetMaskImpl.java_ _@@ -65,7 +65,7 @@_ _"extractSubNet", "BINARY ARRAY :");_ _StringBuffer buff = new StringBuffer();_ _for(int i =0; i < addrLength; i++) {_ _- buff.append((b[i] &0xFF) +":");_ _+ buff.append((b[i] &0xFF)).append(":");_ _}_ _SNMPLOGGER.logp(Level.FINEST, NetMaskImpl.class.getName(),_ _"extractSubNet", buff.toString());_ _diff --git_ _a/src/share/classes/com/sun/org/apache/xml/internal/security/utils/RFC2253Parser.java_ _b/src/share/classes/com/sun/org/apache/xml/internal/security/utils/RFC2253Parser.java_ _---_ _a/src/share/classes/com/sun/org/apache/xml/internal/security/utils/RFC2253Parser.java_ _+++_ _b/src/share/classes/com/sun/org/apache/xml/internal/security/utils/RFC2253Parser.java_ _@@ -98,7 +98,7 @@_ _l += countQuotes(DN, j, k);_ _if ((k > 0) && (DN.charAt(k - 1) != '\') && (l % 2) != 1) { - sb.append(parseRDN(DN.substring(i, k).trim()) + ","); + sb.append(parseRDN(DN.substring(i, k).trim())).append(','); i = k + 1; l = 0; @@ -131,8 +131,7 @@ l += countQuotes(str, j, k); if ((k > 0) && (str.charAt(k - 1) != '\') && (l % 2) != 1) { - sb.append(parseATAV(trim(str.substring(i, k))) + "+"); - + sb.append(parseATAV(trim(str.substring(i, k)))).append("+"); i = k + 1; l = 0; } @@ -386,7 +385,7 @@ int k; for (int j = 0; (k = string.indexOf("\20", j)) >= 0; j = k + 3) { - sb.append(trim(string.substring(i, k)) + "\ "); + sb.append(trim(string.substring(i, k))).append("\ "); i = k + 3; } @@ -436,7 +435,7 @@ l += countQuotes(str, j, k); if ((k > 0) && (str.charAt(k - 1) != '\') && (l % 2) != 1) { - sb.append(trim(str.substring(i, k)) + replace); + sb.append(trim(str.substring(i, k))).append(replace); i = k + 1; l = 0; diff --git a/src/share/classes/com/sun/tools/jdi/VirtualMachineImpl.java b/src/share/classes/com/sun/tools/jdi/VirtualMachineImpl.java --- a/src/share/classes/com/sun/tools/jdi/VirtualMachineImpl.java +++ b/src/share/classes/com/sun/tools/jdi/VirtualMachineImpl.java @@ -881,10 +881,10 @@ } else if (tag == JDWP.TypeTag.ARRAY) { sb.append("ArrayType"); } else { - sb.append("UNKNOWN TAG: " + tag); + sb.append("UNKNOWN TAG: ").append(tag); } if (signature != null) { - sb.append(", signature='" + signature + "'"); + sb.append(", signature='").append(signature).append("'"); } sb.append(", id=" + id); vm.printTrace(sb.toString()); diff --git a/src/share/classes/com/sun/media/sound/WaveExtensibleFileReader.java b/src/share/classes/com/sun/media/sound/WaveExtensibleFileReader.java --- a/src/share/classes/com/sun/media/sound/WaveExtensibleFileReader.java +++ b/src/share/classes/com/sun/media/sound/WaveExtensibleFileReader.java @@ -167,9 +167,9 @@ for (int i = 0; i < allchannelnames.length; i++) {_ _if ((channelmask & m) != 0L) {_ _if (i < channelnames.length) {_ _- sb.append(channelnames[i] + " ");_ _+ sb.append(channelnames[i]).append(" ");_ _} else {_ _- sb.append(allchannelnames[i] + " ");_ _+ sb.append(allchannelnames[i]).append(" ");_ _}_ _}_ _m *= 2L;_ _diff --git_ _a/src/share/classes/com/sun/org/apache/xml/internal/security/encryption/XMLCipher.java_ _b/src/share/classes/com/sun/org/apache/xml/internal/security/encryption/XMLCipher.java_ _---_ _a/src/share/classes/com/sun/org/apache/xml/internal/security/encryption/XMLCipher.java_ _+++_ _b/src/share/classes/com/sun/org/apache/xml/internal/security/encryption/XMLCipher.java_ _@@ -1932,7 +1932,7 @@_ _StringBuffer sb;_ _sb = new StringBuffer();_ _- sb.append("<"+tagname);_ _+ sb.append("<").append(tagname); // Run through each node up to the document node and find any // xmlns: nodes

diff --git a/src/share/classes/com/sun/tools/jdi/VirtualMachineImpl.java b/src/share/classes/com/sun/tools/jdi/VirtualMachineImpl.java --- a/src/share/classes/com/sun/tools/jdi/VirtualMachineImpl.java +++ b/src/share/classes/com/sun/tools/jdi/VirtualMachineImpl.java @@ -881,10 +881,10 @@ } else if (tag == JDWP.TypeTag.ARRAY) { sb.append("ArrayType"); } else { - sb.append("UNKNOWN TAG: " + tag); + sb.append("UNKNOWN TAG: ").append(tag); } if (signature != null) { - sb.append(", signature='" + signature + "'"); + sb.append(", signature='").append(signature).append("'"); } sb.append(", id=" + id); vm.printTrace(sb.toString()); diff --git a/src/share/classes/com/sun/media/sound/WaveExtensibleFileReader.java b/src/share/classes/com/sun/media/sound/WaveExtensibleFileReader.java --- a/src/share/classes/com/sun/media/sound/WaveExtensibleFileReader.java +++ b/src/share/classes/com/sun/media/sound/WaveExtensibleFileReader.java @@ -167,9 +167,9 @@ for (int i = 0; i < allchannelnames.length; i++) {_ _if ((channelmask & m) != 0L) {_ _if (i < channelnames.length) {_ _- sb.append(channelnames[i] + " ");_ _+ sb.append(channelnames[i]).append(" ");_ _} else {_ _- sb.append(allchannelnames[i] + " ");_ _+ sb.append(allchannelnames[i]).append(" ");_ _}_ _}_ _m *= 2L;_ _diff --git_ _a/src/share/classes/com/sun/org/apache/xml/internal/security/encryption/XMLCipher.java_ _b/src/share/classes/com/sun/org/apache/xml/internal/security/encryption/XMLCipher.java_ _---_ _a/src/share/classes/com/sun/org/apache/xml/internal/security/encryption/XMLCipher.java_ _+++_ _b/src/share/classes/com/sun/org/apache/xml/internal/security/encryption/XMLCipher.java_ _@@ -1932,7 +1932,7 @@_ _StringBuffer sb;_ _sb = new StringBuffer();_ _- sb.append("<"+tagname);_ _+ sb.append("<").append(tagname); // Run through each node up to the document node and find any // xmlns: nodes

diff --git a/src/share/classes/com/sun/tools/jdi/VirtualMachineImpl.java b/src/share/classes/com/sun/tools/jdi/VirtualMachineImpl.java --- a/src/share/classes/com/sun/tools/jdi/VirtualMachineImpl.java +++ b/src/share/classes/com/sun/tools/jdi/VirtualMachineImpl.java @@ -881,10 +881,10 @@ } else if (tag == JDWP.TypeTag.ARRAY) { sb.append("ArrayType"); } else { - sb.append("UNKNOWN TAG: " + tag); + sb.append("UNKNOWN TAG: ").append(tag); } if (signature != null) { - sb.append(", signature='" + signature + "'"); + sb.append(", signature='").append(signature).append("'"); } sb.append(", id=" + id); vm.printTrace(sb.toString()); diff --git a/src/share/classes/com/sun/media/sound/WaveExtensibleFileReader.java b/src/share/classes/com/sun/media/sound/WaveExtensibleFileReader.java --- a/src/share/classes/com/sun/media/sound/WaveExtensibleFileReader.java +++ b/src/share/classes/com/sun/media/sound/WaveExtensibleFileReader.java @@ -167,9 +167,9 @@ for (int i = 0; i < allchannelnames.length; i++) {_ _if ((channelmask & m) != 0L) {_ _if (i < channelnames.length) {_ _- sb.append(channelnames[i] + " ");_ _+ sb.append(channelnames[i]).append(" ");_ _} else {_ _- sb.append(allchannelnames[i] + " ");_ _+ sb.append(allchannelnames[i]).append(" ");_ _}_ _}_ _m *= 2L;_ _diff --git_ _a/src/share/classes/com/sun/org/apache/xml/internal/security/encryption/XMLCipher.java_ _b/src/share/classes/com/sun/org/apache/xml/internal/security/encryption/XMLCipher.java_ _---_ _a/src/share/classes/com/sun/org/apache/xml/internal/security/encryption/XMLCipher.java_ _+++_ _b/src/share/classes/com/sun/org/apache/xml/internal/security/encryption/XMLCipher.java_ _@@ -1932,7 +1932,7 @@_ _StringBuffer sb;_ _sb = new StringBuffer();_ _- sb.append("<"+tagname);_ _+ sb.append("<").append(tagname);_ _// Run through each node up to the document node_ _and find any_ _// xmlns: nodes_ _-- javalang_ _diff --git a/src/share/classes/java/lang/invoke/LambdaForm.java_ _b/src/share/classes/java/lang/invoke/LambdaForm.java_ _--- a/src/share/classes/java/lang/invoke/LambdaForm.java_ _+++ b/src/share/classes/java/lang/invoke/LambdaForm.java_ _@@ -708,7 +708,7 @@_ _}_ _public String toString() {_ _- StringBuilder buf = new StringBuilder(debugName+"=Lambda(");_ _+ StringBuilder buf = new_ _StringBuilder(debugName).append("=Lambda(");_ _for (int i = 0; i < names.length; i++) {_ _if (i == arity) buf.append(")=>{"); Name n = names[i]; -- Atenciosamente. Otávio Gonçalves de Santana blog: http://otaviosantana.blogspot.com.br/ twitter: http://twitter.com/otaviojava site: http://www.otaviojava.com.br (11) 98255-3513

More information about the core-libs-dev mailing list