RFR : 7129185 : (M) Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set} (original) (raw)
Martin Buchholz martinrb at google.com
Wed Jun 12 18:49:00 UTC 2013
- Previous message: RFR : 7129185 : (M) Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set}
- Next message: RFR : 7129185 : (M) Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set}
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Thanks for doing this. Arguably, I or Josh or Doug should have done this for jdk6. It's tedious to get all the details right.
Mostly looks good.
I suspect the set returned by emptySortedSet is not serialization-compatible between jdk8 and previous jdks.
Extending EmptySortedSet to also implement NavigableSet ought to be both more compatible and more efficient. And more tedious!
The code fragment below doesn't actually work, cuz WeakHashMap is not a NavigableMap.
* in the following code fragment:* <pre> {@code* Set<Object> weakHashSet =
Collections.newNavigableSetFromNavigableMap(
* new WeakHashMap<Object, Boolean>());* }</pre>
It's traditional to only @link to a particular destination once per javadoc block.
* any {@link NavigableMap} implementation. There is no need to use this* method on a {@link NavigableMap} implementation that already has a
On Mon, Jun 10, 2013 at 4:36 PM, Mike Duigou <mike.duigou at oracle.com> wrote:
I've done some further updates based upon feedback. I believe this is now "done" and ready for final review.
http://cr.openjdk.java.net/~mduigou/JDK-7129185/3/webrev/ I did find one inconsistency in the implementations SortedSet.headSet and SortedSet.tailSet methods. Mike
On Jun 7 2013, at 10:58 , Mike Duigou wrote: > Hello all; > > I've incorporated feedback from previous rounds and expect to finalize this addition soon. > > http://cr.openjdk.java.net/~mduigou/JDK-7129185/2/webrev/ > > Any review feedback or suggestions of additional tests welcome. > > Thanks, > > Mike > >
- Previous message: RFR : 7129185 : (M) Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set}
- Next message: RFR : 7129185 : (M) Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set}
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]