RFR (S) CR 8016236: Class.getGenericInterfaces performance improvement (original) (raw)
Aleksey Shipilev aleksey.shipilev at oracle.com
Mon Jun 17 12:32:46 UTC 2013
- Previous message: RFR (S) CR 8016236: Class.getGenericInterfaces performance improvement
- Next message: RFR (S) CR 8016236: Class.getGenericInterfaces performance improvement
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 06/17/2013 03:44 PM, Alan Bateman wrote:
This looks to good. I agree with Peter's point about the 2 reads in getInterfaces() although it's unlikely to make a significant difference.
Oh, it can have the difference on non-x86 hardware and/or in optimized code. This nit is fixed here: http://cr.openjdk.java.net/~shade/8016236/webrev.04/
I did the same testing as before: Linux x86_64/release builds and runs jdk/test/java/lang/reflect jtreg successfully; the performance is still there.
If you can create the change-set then I can push this for you today.
Here: http://cr.openjdk.java.net/~shade/8016236/8016236.changeset
Although only Alan counts as official reviewer; do we need another one?
Thanks, -Aleksey.
- Previous message: RFR (S) CR 8016236: Class.getGenericInterfaces performance improvement
- Next message: RFR (S) CR 8016236: Class.getGenericInterfaces performance improvement
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]