RFR 7192954+4396272: Fix Float.parseFloat to round correctly and preserve monotonicity (original) (raw)

Brian Burkhalter brian.burkhalter at oracle.com
Fri Jun 21 00:24:43 UTC 2013

Hi Martin,

On Jun 20, 2013, at 4:24 PM, Martin Buchholz wrote:

This change Looks Good To Me.

Cool - thanks!

It would be good in future to cc the contributors.

Good point. It probably is best not to assume that everyone is on core-libs-dev.

Just to show that I'm paying attention, add an extra asterisk below to make this a proper javadoc comment (not that it matters much).

1048 /* 1049 * Takes a FloatingDecimal, which we presumably just scanned in, 1050 * and finds out what its value is, as a double. 1051 * 1052 * AS A SIDE EFFECT, SET roundDir TO INDICATE PREFERRED 1053 * ROUNDING DIRECTION in case the result is really destined 1054 * for a single-precision float. 1055 */ 1056 @Override 1057 public double doubleValue() {

I'll make this change and update the webrev tomorrow.

Thanks,

Brian

More information about the core-libs-dev mailing list