JDK 8 code review request for java.math doclint (original) (raw)

JDK 8 code review request for java.math doclint / accessibility cleanup

Lance Andersen Lance.Andersen at oracle.com
Wed Jun 26 20:06:54 UTC 2013

Hi Joe,

Looks fine

Best Lance On Jun 26, 2013, at 3:21 PM, Joe Darcy <joe.darcy at oracle.com> wrote:

Hello,

Please review the changes in the patch below; these change address the doclint and HTML accessibility issues in java.math. I'll find an existing bug or if one is not present, file a new bug to cover this work. Thanks, -Joe diff -r 336e5a862013 src/share/classes/java/math/BigDecimal.java --- a/src/share/classes/java/math/BigDecimal.java Wed Jun 26 11:21:01 2013 -0700 +++ b/src/share/classes/java/math/BigDecimal.java Wed Jun 26 12:20:28 2013 -0700 @@ -2572,6 +2572,9 @@ * ({@code this} * 10n). The scale of * the result is {@code (this.scale() - n)}. * + * @param n the exponent power to ten to scale by + * @return a BigDecimal whose numerical value is equal to + * ({@code this} * 10n) * @throws ArithmeticException if the scale would be * outside the range of a 32-bit integer. * diff -r 336e5a862013 src/share/classes/java/math/RoundingMode.java --- a/src/share/classes/java/math/RoundingMode.java Wed Jun 26 11:21:01 2013 -0700 +++ b/src/share/classes/java/math/RoundingMode.java Wed Jun 26 12:20:28 2013 -0700 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2003, 2011, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2003, 2013, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -101,6 +101,7 @@ * *

Example:

*
 + * Rounding mode UP Examples *Input Number * Input rounded to one digit
with {@code UP} rounding *5.5 6 @@ -124,6 +125,7 @@ * *

Example:

 *
 + * Rounding mode DOWN Examples *Input Number * Input rounded to one digit
with {@code DOWN} rounding *5.5 5 @@ -148,6 +150,7 @@ * *

Example:

 *
 + * Rounding mode CEILING Examples *Input Number * Input rounded to one digit
with {@code CEILING} rounding *5.5 6 @@ -172,6 +175,7 @@ * *

Example:

 *
 + * Rounding mode FLOOR Examples *Input Number * Input rounded to one digit
with {@code FLOOR} rounding *5.5 5 @@ -198,6 +202,7 @@ * *

Example:

 *
 + * Rounding mode HALFUP Examples *Input Number * Input rounded to one digit
with {@code HALFUP} rounding *5.5 6 @@ -223,6 +228,7 @@ * *

Example:

 *
 + * Rounding mode HALFDOWN Examples *Input Number * Input rounded to one digit
with {@code HALFDOWN} rounding *5.5 5 @@ -255,6 +261,7 @@ * *

Example:

 *
 + * Rounding mode HALFEVEN Examples *Input Number * Input rounded to one digit
with {@code HALFEVEN} rounding *5.5 6 @@ -278,6 +285,7 @@ * {@code ArithmeticException} is thrown. *

Example:

 *
 + * Rounding mode UNNECESSARY Examples *Input Number * Input rounded to one digit
with {@code UNNECESSARY} rounding *5.5 throw {@code ArithmeticException}

Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen at oracle.com

More information about the core-libs-dev mailing list