JDK 8 code review request for doclint fixes in java.util.jar.Pack200 (original) (raw)

Lance Andersen - Oracle Lance.Andersen at oracle.com
Sun Jun 30 23:31:38 UTC 2013

looks good Joe On Jun 30, 2013, at 7:20 PM, Joe Darcy wrote:

Hello,

Pack200 has some doclint issues; please review the fixes to them below. Thanks, -Joe --- a/src/share/classes/java/util/jar/Pack200.java Sun Jun 30 16:02:11 2013 -0700 +++ b/src/share/classes/java/util/jar/Pack200.java Sun Jun 30 16:19:25 2013 -0700 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2003, 2012, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2003, 2013, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -112,7 +112,7 @@ // Static methods of the Pack200 class. /** * Obtain new instance of a class that implements Packer. - * + *

    *

  • If the system property java.util.jar.Pack200.Packer

    •  * is defined, then the value is taken to be the fully-qualified name * of a concrete implementation class, which must implement Packer. @@ -122,6 +122,7 @@ *

  • If an implementation has not been specified with the system

    •  * property, then the system-default implementation class is instantiated, * and the result is returned.

    + * * *

    Note: The returned object is not guaranteed to operate

     * correctly if multiple threads use it at the same time. @@ -137,7 +138,7 @@ /** * Obtain new instance of a class that implements Unpacker. - * + *
      *

    • If the system property java.util.jar.Pack200.Unpacker

      •  * is defined, then the value is taken to be the fully-qualified * name of a concrete implementation class, which must implement Unpacker. @@ -147,6 +148,7 @@ *

    • If an implementation has not been specified with the

      •  * system property, then the system-default implementation class * is instantiated, and the result is returned.

       + * * *

      Note: The returned object is not guaranteed to operate

       * correctly if multiple threads use it at the same time. @@ -350,14 +352,14 @@ * directory will be passed also. *

      * Examples: - *
      + * 
      {@code
       * Map p = packer.properties(); * p.put(PASSFILEPFX+0, "mutants/Rogue.class"); * p.put(PASSFILEPFX+1, "mutants/Wolverine.class"); * p.put(PASSFILEPFX+2, "mutants/Storm.class"); * # Pass all files in an entire directory hierarchy: * p.put(PASSFILEPFX+3, "police/"); - * . + * } */ String PASSFILEPFX = "pack.pass.file."; @@ -378,12 +380,12 @@ * This is the default value for this property. *

      * Examples: - *
      + * 
      {@code
       * Map p = pack200.getProperties(); * p.put(UNKNOWNATTRIBUTE, ERROR); * p.put(UNKNOWNATTRIBUTE, STRIP); * p.put(UNKNOWNATTRIBUTE, PASS); - * + * } */ String UNKNOWNATTRIBUTE = "pack.unknown.attribute";

      -------------- next part --------------

      Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen at oracle.com

      More information about the core-libs-dev mailing list