Request for review: 7190897 (fs) Files.isWritable method returns false when the path is writable (win). (original) (raw)
Alan Bateman Alan.Bateman at oracle.com
Fri Mar 1 15:02:10 UTC 2013
- Previous message: Request for review: 7190897 (fs) Files.isWritable method returns false when the path is writable (win). - ver. 1
- Next message: Request for review: 7190897 (fs) Files.isWritable method returns false when the path is writable (win). - ver. 1
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 01/03/2013 11:45, Alexey Utkin wrote:
That is possible, but includes pre-requirements for installed MS tools. That is not a good idea. I agree.
New version of the fix was prepared. Bug description: http://bugs.sun.com/viewbug.do?bugid=7190897 https://jbs.oracle.com/bugs/browse/JDK-7190897 The suggested fix: http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-7190897/webrev.01/ This looks much better, thank you.
A minor point is that in checkAccessMask then you could call OpenThreadToken before the try/finally. That way you wouldn't need to check hToken. Otherwise I think this is good to go and it's nice to finally fix this issue.
-Alan
- Previous message: Request for review: 7190897 (fs) Files.isWritable method returns false when the path is writable (win). - ver. 1
- Next message: Request for review: 7190897 (fs) Files.isWritable method returns false when the path is writable (win). - ver. 1
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]