Define JNIEXPORT as visibility default with GCC? (original) (raw)
Martin Buchholz martinrb at google.com
Wed Mar 6 01:45:20 UTC 2013
- Previous message: hg: jdk8/tl/jdk: 12 new changesets
- Next message: Define JNIEXPORT as visibility default with GCC?
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Another rev of this change. I added the condition check for gcc > 4.2 (I don't much care either way)
I just ran "clang" for the first time, and was surprised that clang has values of GNUC == 4 and GNUC_MINOR == 2
I think we should keep the __has_attribute check, because it seems clearly correct and recommended by http://clang.llvm.org/docs/LanguageExtensions.html#feature-checking-macros and with luck, __has_attribute will become a minor industry standard from the innovators in llvm-land. I really like the design of their extension mechanisms.
On Wed, Feb 27, 2013 at 3:07 PM, Martin Buchholz <martinrb at google.com>wrote:
Here's the latest version of the proposed patch:
http://cr.openjdk.java.net/~martin/webrevs/openjdk8/JNIEXPORT/ that has been tested, but only with gcc 4.6, but is also written to work with llvm.
- Previous message: hg: jdk8/tl/jdk: 12 new changesets
- Next message: Define JNIEXPORT as visibility default with GCC?
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]