Request for review- RFE 8005716 (original) (raw)

Alan Bateman Alan.Bateman at oracle.com
Tue Mar 12 12:36:08 UTC 2013

On 11/03/2013 15:37, BILL PITTORE wrote:

On 3/11/2013 9:40 AM, Alan Bateman wrote:

On 08/03/2013 02:22, BILL PITTORE wrote:

Moved the string allocation into buildJniFunctionName as Alan suggested. Built and tested on windows and linux. Updated the webrev:

http://cr.openjdk.java.net/~bpittore/8005716/jdk-webrev.02/

bill I see this updates the method descriptions to take on board Jeremy's comment on the possibility of the library being statically linked with the main executable with or without the VM. To be complete, I think this will require an update to the UnstatisfiedLinkError description too. Thanks for moving the sizing/allocation of the function name into buildJniFunctionName as that is cleaner and safer. Is FILENAMEMAX really the right limit to impose? Maybe JVMMAXPATHLEN is the better choice. As it's a symbol rather than a file path then it's probably not right either. I guess the question is whether a limit needs to be checked here or not.

-Alan.

More information about the core-libs-dev mailing list