Review Request: JDK-8001334 - Remove use of JVM_* functions from java.io code (original) (raw)

Alan Bateman Alan.Bateman at oracle.com
Tue Mar 12 15:19:24 UTC 2013

On 11/03/2013 23:43, Dan Xu wrote:

Thanks for all your comments. I have updated the fix accordingly. Please see the webrev at http://cr.openjdk.java.net/~dxu/8001334/webrev.02/.

For the language concern in getLastErrorString(char *buf, sizet len) function, I will log another bug and address it later. Thanks! -Dan You've addressed all my comments but I think I may have confused you on one point when I mentioned O_APPEND. You've changed handleAppend to use fcntl(F_GETFL) and check if the flag is set but this will happen on every write in append mode and we don't want that. I think you can simply change IO_Append to be handleWrite or else have handleAppend call handleWrite. The jboolean flag isn't needed for the *nix case.

-Alan.

More information about the core-libs-dev mailing list