Please review fix for JDK-8010083: Fix ASM doc comments to avoid javadoc errors (original) (raw)
Kumar Srinivasan kumar.x.srinivasan at oracle.com
Fri Mar 15 14:31:06 UTC 2013
- Previous message: Please review fix for JDK-8010083: Fix ASM doc comments to avoid javadoc errors
- Next message: hg: jdk8/tl/jdk: 8005716: Enhance JNI specification to allow support of static JNI libraries in Embedded JREs
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
I concur too, I will chat with the Objectweb folks and see what needs to be done.
Kumar
----- Original Message -----
On 14/03/2013 14:03, A. Sundararajan wrote:
Please review http://cr.openjdk.java.net/~sundar/8010083/
Thanks -Sundar This looks okay to me but do we want to be changing the ASM source? It has a few compiler warnings too. Maybe Rémi or someone closer to ASM could get the issues fixed upstream (if they aren't already) so that we are not out of sync. I'd concur with that statement. Making local changes to upstream code can become a headache in the long run. So speaks the maintainer of a project that does just that with OpenJDK... ;) -Alan
- Previous message: Please review fix for JDK-8010083: Fix ASM doc comments to avoid javadoc errors
- Next message: hg: jdk8/tl/jdk: 8005716: Enhance JNI specification to allow support of static JNI libraries in Embedded JREs
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]