RFR-8008118 (original) (raw)

Alan Bateman Alan.Bateman at oracle.com
Thu Mar 21 19:05:29 UTC 2013


On 21/03/2013 18:36, John Zavgren wrote:

All:

How does this look? 1.) I reverted the for statement formatting change. 2.) I removed the goto statement and "inlined" some code instead. 3.) I checked to make sure that we're not freeing memory that we didn't actually allocate. (Path vector elements that are empty.)

http://cr.openjdk.java.net/~jzavgren/8008118/webrev.04/ John On line 262 then shouldn't this be pathv[i] = cwd;

The recovery when NEW fails looks right to me although while (--i >= 0) { ... } might be clearer.

-Alan.



More information about the core-libs-dev mailing list