RFR-8008118 (original) (raw)
Christos Zoulas christos at zoulas.com
Wed Mar 27 01:58:19 UTC 2013
- Previous message: RFR-8008118
- Next message: RFR-8008118
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On Mar 26, 6:13pm, martinrb at google.com (Martin Buchholz) wrote: -- Subject: Re: RFR-8008118
| Here is my alternative set of perfectionist changes:
:-)
| # Fix PATH handling | http://cr.openjdk.java.net/~martin/webrevs/openjdk8/pathv/
LGTM, only question is why error from one allocation throws and from the other does not? I would move the throw after the:
if (splitpath == NULL || pathv == NULL) {This way we don't need to pass env to xstrdup(). Now you are going to make me grep on how many xstrdup()'s are in the tree :-)
Correct and simple otherwise.
christos
- Previous message: RFR-8008118
- Next message: RFR-8008118
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]