DefaultProxySelector socks override (original) (raw)

Christos Zoulas christos at zoulas.com
Wed Mar 27 17:49:10 UTC 2013


On Mar 27, 5:30pm, chris.hegarty at oracle.com (Chris Hegarty) wrote: -- Subject: Re: DefaultProxySelector socks override

| On 03/27/2013 05:22 PM, christos at zoulas.com wrote: | > .... | > Sure, I just requested a subscription to net-dev so I might not see the | > first few messages. To clarify: | > | > 1. I will add socks.proxyHost and socks.proxyPort for consistency | > with the other protocols, leaving as is socksProxyHost and | > socksProxyPort for compatibility. | > 2. I will add socks.nonProxyHosts and not socksNonProxyHosts. | > | > Is that what you had in mind? || Re-checking the code I take back my previous comment. We already have || socksProxyHost, socksProxyPort, socksProxyVersion || so your original proposal of 'socksNonProxyHosts' is probably best, and | consistent with existing properties.

I concur. Nothing for me to do :-)

Best,

christos



More information about the core-libs-dev mailing list