RFR: Optimize StringBuilder.append(null) (original) (raw)

Remi Forax forax at univ-mlv.fr
Thu Mar 28 06:32:22 UTC 2013


On 03/28/2013 07:29 AM, Martin Buchholz wrote:

On Wed, Mar 27, 2013 at 4:36 PM, Remi Forax <forax at univ-mlv.fr_ _<mailto:forax at univ-mlv.fr>> wrote: On 03/27/2013 03:01 AM, Martin Buchholz wrote: Hi Martin, the code looks good, I've just noticed that you declare the char array value final in appendNull but it's not something that is usually done in the java.lang codebase. It's certainly common in java.util.concurrent. It's safer.

I was talking about the local variable in appendNull() ? IMO, marking the local variable final makes the code less readable

The declaration saves 50 bytes of bytecode.

I don't understand ?

Rémi



More information about the core-libs-dev mailing list