RFR: JDK-8013225: Refresh jdk's private ASM to the latest. (original) (raw)

A. Sundararajan sundararajan.athijegannathan at oracle.com
Thu May 2 04:02:25 UTC 2013

Hi Kumar,

So long as those nashorn tests (jtreg tests under jdk/test/javax/script,jdk/test/javax/script, jdk/test/javax/script,jdk/sun/tools/jrunscript, $nashorn/test and nashorn ant tests - $nashorn/make - ant test) run fine, we've no objections from nashorn team.

Thanks -Sundar

On Tuesday 30 April 2013 03:55 AM, Kumar Srinivasan wrote:

The restyling changes obfustucated things a bit but I didn't see anything of concern in casual review.

I had hoped to see the updated SmallSet that didn't try to implement Iterator directly. It looks the SmallSet needs more discussion.. barring that anyone else have any other concerns with this change ? If I don't hear any objections I will push this on 05/01. Thanks Kumar

Looks OK. The testing, which you have done, is the important qualifier for this change. Mike On Apr 25 2013, at 13:24 , Kumar Srinivasan wrote: Here is the webrev: http://cr.openjdk.java.net/~ksrini/8013225/webrev.0/

Thanks Kumar

Hello,

Please review changes which essentially contains asm5future in asm's mainline repository, I have tested this patch with Nashorn (so has Sundar), as well as Lambda's usage. Fixes that I know of: 1. supports v52.0 class files and JSR 308/Type Annotations changes Thanks to Remi 2. elimination of "" usages in variable names 3. several javadoc changes and one reported by Sundar http://jbs.oracle.com/bugs/browse/JDK-8010083

Thanks Kumar

More information about the core-libs-dev mailing list