RFR: 8013155: [pack200] improve performance of pack200 (original) (raw)
Kumar Srinivasan kumar.x.srinivasan at oracle.com
Thu May 2 15:14:31 UTC 2013
- Previous message: RFR: 8013155: [pack200] improve performance of pack200
- Next message: RFR: JDK-8008738 - Issue in com.sun.org.apache.xml.internal.serializer.Encodings causes some JCK tests to fail intermittently
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Looks good.
Kumar
Kumar,
On 4/30/13 22:32, Kumar Srinivasan wrote: Couple of nits: I don't think you need the parens
j = (nextsemi < nextangl ? nextsemi : nextangl);_ _Here i tend to agree with John - the condition being a superposition_ _of two really closely named_ _variables might look confusing and since the world supply of_ _parentheses is not limited i will humbly_ _ask for permission to leave one extra pair of them there._ _Coding conventions nits:_ _missing spaces for operators._ _for (int i = firstl+1, j; i > 0; i = sig.indexOf('L', j)+1) { Fixed. I take it all the regression tests have been run ? in jdk/test/tools/pack200. Sure - since it is not platform-specific code i took liberty to perform testing on Mac OS and Linux only - all the pack200 regression tests are passed. The updated webrev can be seen here: http://cr.openjdk.java.net/~kizune/8013155/webrev.01 With best regards, Alex
- Previous message: RFR: 8013155: [pack200] improve performance of pack200
- Next message: RFR: JDK-8008738 - Issue in com.sun.org.apache.xml.internal.serializer.Encodings causes some JCK tests to fail intermittently
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]