RFR JDK-8003258(2nd round): BufferedReader.lines() (original) (raw)
Henry Jen henry.jen at oracle.com
Thu May 2 16:00:55 UTC 2013
- Previous message: RFR JDK-8003258(2nd round): BufferedReader.lines()
- Next message: RFR: JDK-8006884: (fs) Add Files.list, lines and find
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 05/02/2013 05:08 AM, Alan Bateman wrote:
On 02/05/2013 07:49, Henry Jen wrote:
Hi,
Take feedbacks from previous round, the javadoc is updated http://cr.openjdk.java.net/~henryjen/ccc/8003258.2/webrev/ http://cr.openjdk.java.net/~henryjen/ccc/8003258.2/specdiff/ This looks good to me except for the last two sentences of the final paragraph: "For example, when trying toread from the Stream after the BufferedReaderis closed, will throw an UncheckedIOException. Note thatmethod will return the Stream Stream even if this BufferedReader is closed, but the operation cause reading will throwUncheckedIOException." How about: "This method will return a Stream if invoked on a BufferedReader that is closed. Any operation on that stream requires reading from the BufferedReader after is it closed will cause an UncheckedIOException to be thrown".
Updated as suggested.
Otherwise I think we are at the finish line.
Cheers, Henry
- Previous message: RFR JDK-8003258(2nd round): BufferedReader.lines()
- Next message: RFR: JDK-8006884: (fs) Add Files.list, lines and find
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]