Please review changes for JDK-8012975: Remove rhino from jdk8 (original) (raw)

Tim Bell tim.bell at oracle.com
Fri May 3 06:23:51 UTC 2013

On 05/ 2/13 01:24 PM, I wrote:

Hi Sundar:

Oracle JDK includes Rhino based javax.script implementation (which lives mostly in "closed" code). Rhino is being removed from Oracle JDK builds and there are the changes to the jdk open repository as well like com.sun.script.javascript package, makefiles etc. Please review the open jdk changes here:

http://cr.openjdk.java.net/~sundar/8012975/ This looks good. Approved. Tim

Sundar - we have had some breakage in the build forest recently, so to be extra careful I created a forest and then added your changes. I also did some blasting away with 'find ... -print | xargs egrep ...' commands to look for traces of rhino or javascript.

I think you need to look at removing these files as well:

jdk/make/com/sun/script/Makefile jdk/make/sun/org/mozilla/javascript/Makefile

Tim

More information about the core-libs-dev mailing list