Review request for JDK-4487672 (proxy) Proxy constructor should check for null argument (original) (raw)

Mandy Chung mandy.chung at oracle.com
Thu May 9 17:38:25 UTC 2013

On 5/9/13 3:00 AM, Alan Bateman wrote:

On 09/05/2013 01:13, Mandy Chung wrote:

Please review the simple change for: JDK-4487672 (proxy) Proxy constructor should check for null argument

Webrev at: http://cr.openjdk.java.net/~mchung/jdk8/webrevs/4487672/webrev.00/ It looks okay to me although technically an incompatible change. I guess it will at least have the NPE caught earlier that it would if the handler were actually used.

Yes it is technically an incompatible change.

Existing code that constructs a dynamic proxy instance with null argument doesn't get NPE but instead NPE will bethrown at a later time when a method of the proxy instance is invoked. It's expected that such usage should be very rare as such proxy instance has no use at all.

thanks Mandy

More information about the core-libs-dev mailing list