Request for Review 8014296: DivModTests should not compare pointers (original) (raw)
Joe Darcy joe.darcy at oracle.com
Fri May 10 15:14:21 UTC 2013
- Previous message: Request for Review 8014296: DivModTests should not compare pointers
- Next message: Request for Review 8014296: DivModTests should not compare pointers
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 05/10/2013 08:02 AM, roger riggs wrote:
Please review this minor correction to DivModTests to address this issue: http://bugs.sun.com/viewbug.do?bugid=8014296
With autoboxing of mixed types primitive and Object, the operators == and != are interpreted as reference compare instead of value compares. The compiler is silent about the likely unintended consequences. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-8014296-DivModTests/ Thanks, Roger
Roger,
The copyright range should now be "2012, 2013,".
Otherwise, the change looks fine.
-Joe
- Previous message: Request for Review 8014296: DivModTests should not compare pointers
- Next message: Request for Review 8014296: DivModTests should not compare pointers
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]