Request for Review 8014296: DivModTests should not compare pointers (original) (raw)
Joe Darcy joe.darcy at oracle.com
Fri May 10 16:07:34 UTC 2013
- Previous message: Request for Review 8014296: DivModTests should not compare pointers
- Next message: hg: jdk8/tl/langtools: 8014318: tools/javac/profiles/ProfileOptionTest.java needs modifying now that javax.script is in compact1
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Pushed; cheers,
-Joe
On 05/10/2013 08:40 AM, roger riggs wrote:
Thanks, I'll need help with the push (I'm not a committer for JDK).
On 5/10/2013 11:39 AM, Joe Darcy wrote: Good to push.
-Joe On 05/10/2013 08:25 AM, roger riggs wrote: Thanks, the webrev now has the correct copyright change.
On 5/10/2013 11:14 AM, Joe Darcy wrote: On 05/10/2013 08:02 AM, roger riggs wrote: Please review this minor correction to DivModTests to address this issue: http://bugs.sun.com/viewbug.do?bugid=8014296
With autoboxing of mixed types primitive and Object, the operators == and != are interpreted as reference compare instead of value compares. The compiler is silent about the likely unintended consequences. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-8014296-DivModTests/ Thanks, Roger
Roger, The copyright range should now be "2012, 2013,". Otherwise, the change looks fine. -Joe
- Previous message: Request for Review 8014296: DivModTests should not compare pointers
- Next message: hg: jdk8/tl/langtools: 8014318: tools/javac/profiles/ProfileOptionTest.java needs modifying now that javax.script is in compact1
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]