Code review request, JDK-8010814, More buffers are stored or returned without cloning (original) (raw)

Weijun Wang weijun.wang at oracle.com
Thu May 16 09:22:34 UTC 2013

Hi Xuelei

I'm busy on something else, so probably have no time (or cannot concentrate) to read in details.

In my opinion, there are several cases as to whether to clone or not:

MUST NOT clone, because the value must be shared so that change at one side appears on the other side.
MUST clone, public available methods that leads to security issues.
So so, although public methods, cannot be used to do bad things.
Not an issue. Internal methods.

In the patch, are the first two cases #1 or #3.

Sorry I also have no time to read

JDK-8010814, More buffers are stored or returned without cloning http://cr.openjdk.java.net/~xuelei/8010815/webrev.00/

but I am not sure if those env cases belong to #1.

Thanks Max

On 5/16/13 5:08 PM, Xuelei Fan wrote:

Hi,

There is another fix to avoid the use of mutable objects. webrev: http://cr.openjdk.java.net/~xuelei/8010814/webrev.00/ Thanks, Xuelei