RFR 8005704: Update ConcurrentHashMap to v8 (original) (raw)
Chris Hegarty chris.hegarty at oracle.com
Mon May 27 14:30:17 UTC 2013
- Previous message: hg: jdk8/tl/langtools: 7030476: Fix conflicting use of JCTree/JCExpression
- Next message: RFR 8005704: Update ConcurrentHashMap to v8
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Since my previous failed attempt to update the j.u.c. world, this review is for the update to j.u.c.ConcurrentHashMap v8 from Doug's CVS.
http://cr.openjdk.java.net/~chegar/8005704/ver.00/specdiff/java/util/concurrent/package-summary.html http://cr.openjdk.java.net/~chegar/8005704/ver.00/webrev/
A few initial comments:
CHM no longer extends AbstractMap. I guess this should not be a problem in the real world, and I guess users would not be too surprised by instanceof checks. Just worth highlighting the change for compatibility.
KeySetView.spliterator()
I guess the API should also report CONCURRENT, NONNULL & SUBSIZED? And the implementation should return SIZED too?
Value/EntrySpliterator.spliterator() should return SIZED?
Does is make sense for KeySetView to be Serializable? It looks a little odd with value as its only field.
-Chris.
- Previous message: hg: jdk8/tl/langtools: 7030476: Fix conflicting use of JCTree/JCExpression
- Next message: RFR 8005704: Update ConcurrentHashMap to v8
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]