RFR 8014409: Spec typo: extra } in the spec for j.u.s.StreamBuilder (original) (raw)

Chris Hegarty chris.hegarty at oracle.com
Wed May 29 12:49:40 UTC 2013

Looks fine to me Paul.

Trivially, there is an extra space which could be removed.

"builder__has..."

-Chris.

On 29/05/2013 12:08, Paul Sandoz wrote:

Hi,

Please review these JavaDoc fixes to j.u.s.StreamBuilder. Paul. # HG changeset patch # User psandoz # Date 1369825073 -7200 # Node ID 303e9d2aff3cbaf27823b2591f2e8570b77afcce # Parent bd6d3801347bfd912507d16dc14488f47e94e626 8014409: Spec typo: extra } in the spec for j.u.s.StreamBuilder Summary: Also fixes documentation on StreamBuilder.OfDouble Reviewed-by: diff -r bd6d3801347b -r 303e9d2aff3c src/share/classes/java/util/stream/StreamBuilder.java --- a/src/share/classes/java/util/stream/StreamBuilder.java Wed May 29 09:42:39 2013 +0200 +++ b/src/share/classes/java/util/stream/StreamBuilder.java Wed May 29 12:57:53 2013 +0200 @@ -38,7 +38,7 @@ *

A {@code StreamBuilder} has a lifecycle, where it starts in a building

* phase, during which elements can be added, and then transitions to a built * phase, after which elements may not be added. The built phase begins - * when the {@link #build()}} method is called, which creates an ordered + * when the {@link #build()} method is called, which creates an ordered * {@code Stream} whose elements are the elements that were added to the stream * builder, in the order they were added. * @@ -98,7 +98,7 @@ *

A stream builder has a lifecycle, where it starts in a building

 * phase, during which elements can be added, and then transitions to a * built phase, after which elements may not be added. The built phase - * begins when the {@link #build()}} method is called, which creates an + * begins when the {@link #build()} method is called, which creates an * ordered stream whose elements are the elements that were added to the * stream builder, in the order they were added. * @@ -155,7 +155,7 @@ *

A stream builder has a lifecycle, where it starts in a building

 * phase, during which elements can be added, and then transitions to a * built phase, after which elements may not be added. The built phase - * begins when the {@link #build()}} method is called, which creates an + * begins when the {@link #build()} method is called, which creates an * ordered stream whose elements are the elements that were added to the * stream builder, in the order they were added. * @@ -209,6 +209,13 @@ /** * A mutable builder for a {@code DoubleStream}. * + *

A stream builder has a lifecycle, where it starts in a building

 + * phase, during which elements can be added, and then transitions to a + * built phase, after which elements may not be added. The built phase + * begins when the {@link #build()} method is called, which creates an + * ordered stream whose elements are the elements that were added to the + * stream builder, in the order they were added. + * * @see LongStream#builder() * @since 1.8 */ @@ -217,13 +224,6 @@ /** * Adds an element to the stream being built. * - *

A stream builder has a lifecycle, where it starts in a building

 - * phase, during which elements can be added, and then transitions to a - * built phase, after which elements may not be added. The built phase - * begins when the {@link #build()}} method is called, which creates an - * ordered stream whose elements are the elements that were added to the - * stream builder, in the order they were added. - * * @throws IllegalStateException if the builder has already transitioned * to the built state */

More information about the core-libs-dev mailing list